Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 7, 2025

can't (and don't need to) use an errgroup as cmd.Wait MUST be ran only after the whole stdout has been parsed by json decoder

@ndeloof ndeloof requested a review from a team as a code owner May 7, 2025 13:28
@ndeloof ndeloof requested a review from glours May 7, 2025 13:28
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge (rebase) May 7, 2025 13:28
Signed-off-by: Nicolas De Loof <[email protected]>
@glours glours merged commit 7cea455 into docker:main May 7, 2025
25 checks passed
@ndeloof ndeloof deleted the simpler branch May 7, 2025 14:06
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request May 20, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.36.0` -> `v2.36.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.36.1`](https://github.com/docker/compose/releases/tag/v2.36.1)

[Compare Source](docker/compose@v2.36.0...v2.36.1)

#### What's Changed

##### ✨ Improvements

-   Provider.options can be an array by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12819
-   Set provider environment by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12817
-   Add support of `debug` messages in the communication between Compose … by [@&#8203;glours](https://github.com/glours) in docker/compose#12826
-   Introduce config `--lock-image-digests` by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12843

##### 🐛 Fixes

-   Skip push step for provider services by [@&#8203;glours](https://github.com/glours) in docker/compose#12818
-   Provider info by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12820
-   Append `.exe` to provider name doing executable lookup on windows by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12832
-   Fix quiet option when using COMPOSE_BAKE=1 by [@&#8203;AnvarU](https://github.com/AnvarU) in docker/compose#12838
-   Do not throw an error on build with provider services by [@&#8203;glours](https://github.com/glours) in docker/compose#12842
-   Report cancelled pull after another one failed by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12840
-   Ensure build dependencies are enabled by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12824

##### 🔧  Internal

-   Simplification by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12811
-   Remove Docker EULA licensing which isn't relevant by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12829
-   Remove convert alias from config command by [@&#8203;glours](https://github.com/glours) in docker/compose#12850

##### ⚙️ Dependencies

-   Build(deps): bump github.com/containerd/containerd/v2 from 2.0.5 to 2.1.0 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#12813
-   Build(deps): bump google.golang.org/grpc from 1.72.0 to 1.72.1 by [@&#8203;dependabot](https://github.com/dependabot) in docker/compose#12837
-   Bump compose-go to v2.6.3 by [@&#8203;glours](https://github.com/glours) in docker/compose#12849

**Full Changelog**: docker/compose@v2.36.0...v2.36.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNS4wIiwidXBkYXRlZEluVmVyIjoiNDAuMTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants