Skip to content

remove Docker EULA licensing which isn't relevant #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

remove Docker EULA licensing which isn't relevant #12829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,6 @@ jobs:
echo "$sum $file" > ${file#\*}.sha256
fi
done
-
name: License
run: cp packaging/* ./bin/release/
Copy link
Member

@thaJeztah thaJeztah May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this one be swapped for the top-level LICENSE, or was a license already added as part of one of the steps?

Copy link
Contributor Author

@ndeloof ndeloof May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK compose is the only docker artifact where we include a LICENSE file with built artifact (for legacy reasons)
Licensing is already set by github project and source code archive

Copy link
Member

@thaJeztah thaJeztah May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right; I wasn't sure if folks would expect it to be there.

I know / recall it's included in the .deb and/or .rpm packages but that's probably separate from this?

-
name: List artifacts
run: |
Expand Down
2 changes: 0 additions & 2 deletions packaging/LICENSE
View file
Open in desktop

This file was deleted.