do not throw an error on build with provider services #12842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guillaume Lours <[email protected]>
ndeloof
approved these changes
May 16, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12842 +/- ##
==========================================
+ Coverage 51.78% 53.51% +1.73%
==========================================
Files 158 158
Lines 16533 16213 -320
==========================================
+ Hits 8562 8677 +115
+ Misses 7096 6657 -439
- Partials 875 879 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
May 20, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.36.0` -> `v2.36.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.36.1`](https://github.com/docker/compose/releases/tag/v2.36.1) [Compare Source](docker/compose@v2.36.0...v2.36.1) #### What's Changed ##### ✨ Improvements - Provider.options can be an array by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12819 - Set provider environment by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12817 - Add support of `debug` messages in the communication between Compose … by [@​glours](https://github.com/glours) in docker/compose#12826 - Introduce config `--lock-image-digests` by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12843 ##### 🐛 Fixes - Skip push step for provider services by [@​glours](https://github.com/glours) in docker/compose#12818 - Provider info by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12820 - Append `.exe` to provider name doing executable lookup on windows by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12832 - Fix quiet option when using COMPOSE_BAKE=1 by [@​AnvarU](https://github.com/AnvarU) in docker/compose#12838 - Do not throw an error on build with provider services by [@​glours](https://github.com/glours) in docker/compose#12842 - Report cancelled pull after another one failed by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12840 - Ensure build dependencies are enabled by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12824 ##### 🔧 Internal - Simplification by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12811 - Remove Docker EULA licensing which isn't relevant by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12829 - Remove convert alias from config command by [@​glours](https://github.com/glours) in docker/compose#12850 ##### ⚙️ Dependencies - Build(deps): bump github.com/containerd/containerd/v2 from 2.0.5 to 2.1.0 by [@​dependabot](https://github.com/dependabot) in docker/compose#12813 - Build(deps): bump google.golang.org/grpc from 1.72.0 to 1.72.1 by [@​dependabot](https://github.com/dependabot) in docker/compose#12837 - Bump compose-go to v2.6.3 by [@​glours](https://github.com/glours) in docker/compose#12849 **Full Changelog**: docker/compose@v2.36.0...v2.36.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4xNS4wIiwidXBkYXRlZEluVmVyIjoiNDAuMTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Avoid to throw an error on build command for provider service as they don't have neither
imageorbuildattributesRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did