feat: Update browser-tools orb so that Chrome for testing and Edge browsers are installed in cypress/install #530

jennifer-shehane · 2025-06-02T17:44:21Z

Close #528

cypress · 2025-06-02T18:09:10Z

circleci-orb Run #304

Run Properties: Failed #304 • 307ffe6b1b: add executor

Project	`circleci-orb`
Branch Review	`bump-browser-tools`
Run status	`Failed #304`
Run duration	`00m 11s`
Commit	`307ffe6b1b: add executor`
Committer	`Jennifer Shehane`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`0`
View all changes introduced in this branch ↗︎

UI Coverage `100%`
Untested elements	`0`
Tested elements	`3`

Accessibility `90.82%`
Failed rules	`0 critical` `0 serious` `3 moderate` `0 minor`
Failed elements	`5`

Tests for review

cypress/e2e/login.cy.ts • 1 failed test

View Output

Test		Artifacts
Authentication > Logs in		`Test Replay` `Screenshots`

jennifer-shehane · 2025-06-02T18:43:49Z

Chrome for Testing isn't installing due to this issue: CircleCI-Public/browser-tools-orb#137

I could theoretically bump our version and get built in Edge support, but I think I'll wait a bit to see if this PR merges.

We also want the version to be optional which is covered here: CircleCI-Public/browser-tools-orb#138

jennifer-shehane · 2025-06-06T13:06:56Z

Fixed and made some requests to browser-tools orb which they addressed in 2.1.0: https://github.com/CircleCI-Public/browser-tools-orb/releases/tag/v2.1.0

MikeMcC399 · 2025-06-10T11:48:35Z

@jennifer-shehane

This PR is trying to run cypress-for-testing using the Cypress Docker image cypress/browsers

This won't work, and is the reason for CI failures, because cypress/browsers only contains Chrome, not Chrome for Testing.

jennifer-shehane · 2025-06-10T13:23:24Z

@MikeMcC399 Yah I'm a bit confused by these tests - I thought it was meant to test itself - like the install browsers part, but it's just using our browsers image...

MikeMcC399 · 2025-06-11T11:59:07Z

@jennifer-shehane

This PR is hitting multiple issues including the fact that Cypress doesn't find the Chrome for Testing installation from CircleCI.

This may need fixes in circleci/browser-tools.

I will dig in deeper and report back what I can find out and if I have any suggestions.

MikeMcC399 · 2025-06-11T17:40:05Z

Issues submitted:

MikeMcC399 · 2025-06-11T17:43:35Z

src/commands/install.yml

      Cypress runs by default in the Electron browser. Use this flag to install additional browsers to run your tests in.
      This is only needed if you are passing the `--browser` flag in your `cypress-command`.
-      This parameter leverages the `circleci/browser-tools` orb and includes Chrome and FireFox.
+      This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for testing, FireFox, and Edge.


Suggested change

This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for testing, FireFox, and Edge.

This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for Testing, FireFox, and Edge.

https://developer.chrome.com/blog/chrome-for-testing/ brands it as "Chrome for Testing"

MikeMcC399 · 2025-06-11T17:45:03Z

src/jobs/run.yml

      Cypress runs by default in the Electron browser. Use this flag to install additional browsers to run your tests in.
      This is only needed if you are passing the `--browser` flag in your `cypress-command`.
-      This parameter leverages the `circleci/browser-tools` orb and includes Chrome and FireFox.
+      This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for testing, FireFox and Edge.


Suggested change

This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for testing, FireFox and Edge.

This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for Testing, FireFox and Edge.

MikeMcC399 · 2025-06-11T17:47:46Z

.circleci/test-deploy.yml

    docker:
      - image: cypress/browsers:22.16.0


Suggested change

docker:

- image: cypress/browsers:22.16.0

executor:

name: cypress/default

MikeMcC399 · 2025-06-11T17:48:11Z

.circleci/test-deploy.yml

  run-ct-tests-in-chrome:
+    executor:
+      name: cypress/default
+      node-version: "22.14.0"


Maybe delete this line and take the default node-version ?

MikeMcC399 · 2025-06-12T14:59:24Z

src/@orb.yml

 orbs:
  node: circleci/node@7
-  browser-tools: circleci/browser-tools@1.5.3
+  browser-tools: circleci/browser-tools@2.1.0


Suggested change

browser-tools: circleci/[email protected].0

browser-tools: circleci/[email protected].1

This is the minimum version required that allows Cypress to detect Chrome for Testing.
See https://github.com/CircleCI-Public/browser-tools-orb/releases/tag/v2.1.1

MikeMcC399 · 2025-06-14T12:59:48Z

src/commands/install.yml

-        - browser-tools/install-browser-tools
+        - browser-tools/install_browser_tools:
+            install_chrome_for_testing: true
+            install_chrome_for_testing_driver: true


Suggested change

install_chrome_for_testing_driver: true

install_edge: true

The driver isn't needed, however Edge is missing

MikeMcC399 · 2025-06-14T15:03:45Z

I suggest to close this PR as there are / were several issues with it and it would be tricky to fix everything here in a transparent way that lends itself to reviewing. Instead, I'm two thirds into replacing it with:

and I would follow up with a final PR to add Chrome for Testing.

The remaining issue is that in https://github.com/cypress-io/circleci-orb/blob/master/.circleci/test-deploy.yml the install-and-persist job doesn't persist browser installations, so you either test in Docker, which means you're not testing the install browser functionality of the orb, or you need to manually install any necessary browser in each test job.

The CircleCI issue preventing Chrome for Testing from being used by Cypress was resolved in CircleCI-Public/browser-tools-orb#141

In parallel I'm also submitting some PRs to the https://github.com/CircleCI-Public/browser-tools-orb to fix their documentation.

MikeMcC399 · 2025-06-16T13:18:51Z

combined, replace this PR

jennifer-shehane added 4 commits June 2, 2025 13:44

bump browser tools

e242fd7

more updates

6ca63ea

fix

a03905e

add chrome for testing job

8e4eb6f

jennifer-shehane added 2 commits June 2, 2025 14:11

remove chrome for testing testing

39ec1a3

try chrome for testing again

b856f72

jennifer-shehane self-assigned this Jun 2, 2025

jennifer-shehane changed the title ~~bump browser tools~~ feat: Update browser-tools orb so that Chrome for testing and Edge browsers are installed in cypress/install Jun 2, 2025

MikeMcC399 mentioned this pull request Jun 3, 2025

Edge example incorrectly published #498

Closed

jennifer-shehane added 3 commits June 6, 2025 09:07

bump to 2.1.0 and adjust for changes

36e7e78

set to install chrome for testing

6f75672

install driver also

b88cabf

jennifer-shehane added 2 commits June 10, 2025 09:25

remove docker image for chrome job

80d81cb

add executor

307ffe6

MikeMcC399 mentioned this pull request Jun 11, 2025

Cypress does not detect Chrome for Testing in CircleCI cypress-io/cypress#31867

Closed

MikeMcC399 reviewed Jun 11, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

MikeMcC399 reviewed Jun 12, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

MikeMcC399 mentioned this pull request Jun 14, 2025

chore(deps): update circleci/browser-tools to 2.1.1 #531

Merged

MikeMcC399 reviewed Jun 14, 2025

View reviewed changes

MikeMcC399 mentioned this pull request Jun 14, 2025

feat: install-browsers: true installs edge #532

Closed

This was referenced Jun 14, 2025

feat: install-browsers: true installs chrome for testing #533

Closed

feat: use CircleCI Chrome for Testing and Edge #534

Merged

jennifer-shehane closed this Jun 16, 2025

	This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for testing, FireFox, and Edge.
	This parameter leverages the `circleci/browser-tools` orb and includes Chrome, Chrome for Testing, FireFox, and Edge.

	browser-tools: circleci/[email protected].0
	browser-tools: circleci/[email protected].1

feat: Update browser-tools orb so that Chrome for testing and Edge browsers are installed in cypress/install #530

feat: Update browser-tools orb so that Chrome for testing and Edge browsers are installed in cypress/install #530

Uh oh!

Conversation

jennifer-shehane commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cypress bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

circleci-orb Run #304

Tests for review

Uh oh!

jennifer-shehane commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jennifer-shehane commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MikeMcC399 commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jennifer-shehane commented Jun 10, 2025

Uh oh!

MikeMcC399 commented Jun 11, 2025

Uh oh!

MikeMcC399 commented Jun 11, 2025

Uh oh!

MikeMcC399 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcC399 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcC399 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcC399 Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

MikeMcC399 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

MikeMcC399 Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcC399 commented Jun 14, 2025

Uh oh!

MikeMcC399 commented Jun 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jennifer-shehane commented Jun 2, 2025 •

edited

Loading

cypress bot commented Jun 2, 2025 •

edited

Loading

jennifer-shehane commented Jun 2, 2025 •

edited

Loading

jennifer-shehane commented Jun 6, 2025 •

edited

Loading

MikeMcC399 commented Jun 10, 2025 •

edited

Loading