feat: install-browsers: true installs edge #532
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Issue Update browser-tools orb to v2 (support for chrome for testing + edge browsers) #528 proposes to support Chrome for Testing and Edge browsers through
v2of the CircleCI Orb circleci/browser-toolsPR feat: Update browser-tools orb so that Chrome for testing and Edge browsers are installed in cypress/install #530 has attempted to implement this proposal, however there are multiple failures in the PR
PR chore(deps): update circleci/browser-tools to 2.1.1 #531 is planned to allow Edge to be installed from circleci/browser-tools
Change
Add
install_edge: trueto src/commands/install.yml so that the commandcypress/install-browsers: trueinstalls Edge in addition to Chrome and Firefox.Update src/examples/edge.yml to use Edge from circleci/browser-tools instead of from the Cypress Docker image
cypress/browsers.In .circleci/test-deploy.yml
run-ct-tests-in-edgeto run in the orb'scypress/defaultinstead of in the Docker imagecypress/browsersThis means that the parameter
install-browsers: trueadditionally installs the Edge browser in: