chore: update Chrome for Testing Script

[AtofStryker]

Checklist

• All new jobs, commands, executors, parameters have descriptions (default case is covered)
• Examples have been added for any significant new features
• README has been updated, if necessary

Motivation, issues

I wanted to use the Chrome for Testing update in version 2 of the orb, but ran into issues, specifically when not passing in a version for Chrome for Testing, where the docs make it seem like its optional, but is in fact required. I also do not have wget installed on my machine and figured curl made more sense since the Chrome and Firefox scripts both use curl. Also, not passing in a version silently fails since the url is invalid.

Description

Updates chrome for testing script to display clearer error messages when version is omitted. I believe the documentation is auto generated and is incorrect since a default value was provided into the .yml file for version when there shouldn't be one. version should be required.

Also allow chromedriver to optionally be installed. Defaults to true to avoid a breaking change. Also cuts over to use curl instead of wget as curl is available on most distributions without needing to install wget.

What is the best way to test this script? I have just been fiddling with it locally 😬 .

[jennifer-shehane]

I just wanted to chime in here that we're also extending from this orb for the Cypress CircleCI Orb and this Chrome for Testing install didn't work on that repo.

It'd be ideal if Chrome for Testing was included in the install_browser_tools with a default version of latest - as our API is expecting a standardized behavior here and not expecting a user to pass a version.

[AtofStryker]

I just wanted to chime in here that we're also extending from this orb for the Cypress CircleCI Orb and this Chrome for Testing install didn't work on that repo.

It'd be ideal if Chrome for Testing was included in the install_browser_tools with a default version of latest - as our API is expecting a standardized behavior here and not expecting a user to pass a version.

We should be able to add https://github.com/AtofStryker/browser-tools-orb/blob/main/src/scripts/install_chrome.sh#L50 to this since its implied that stable channel in release will also be available for chrome for testing. I will add a follow up PR to this one that does this

Also, CI looks to be failing on this PR but doesn't look related to the changes I made? Anyone able to rerun?

[AtofStryker]

@jennifer-shehane attempting to install via latest in #138

[marboledacci]

@jennifer-shehane I'm addressing your request on #139.
When it is ready I will release a new version with that and the improvements made by @AtofStryker

[MikeMcC399]

@marboledacci

When it is ready I will release a new version with that and the improvements made by @AtofStryker

CircleCI badges are still broken and don't get updated automatically. See https://discuss.circleci.com/t/orb-badge-versions-out-of-date/53191

I've updated this one:

Right-click badge in README
Copy image address
https://camo.githubusercontent.com/0b0bd617ea8e6a5cca5e5bfa227fdc75a13effaa4ff8ae6275f2b698a5d7b2e3/68747470733a2f2f6261646765732e636972636c6563692e636f6d2f6f7262732f636972636c6563692f62726f777365722d746f6f6c732e737667

Execute

curl -X PURGE https://camo.githubusercontent.com/0b0bd617ea8e6a5cca5e5bfa227fdc75a13effaa4ff8ae6275f2b698a5d7b2e3/68747470733a2f2f6261646765732e636972636c6563692e636f6d2f6f7262732f636972636c6563692f62726f777365722d746f6f6c732e737667

In browser Ctrl-F5 to refresh local cache.

[marboledacci]

@MikeMcC399 the badges are not broken. As you mention the problem is cache. The easy fix in general is doing a hard refresh on the browser (ctrl + shift + R or cmd + shift + R).
I will check with the team who manages those endpoints to see if they support some kind of cache control

[MikeMcC399]

@marboledacci

@MikeMcC399 the badges are not broken. As you mention the problem is cache. The easy fix in general is doing a hard refresh on the browser (ctrl + shift + R or cmd + shift + R). I will check with the team who manages those endpoints to see if they support some kind of cache control

Sorry if I didn't describe the problem well. Yes, the problem is the lack of cache control. I already raised it with support and the engineering team were supposed to be looking at cache control. I didn't hear back on the outcome as the case was then closed.

It will be great if you can raise this again as it affects every repo using these badges.

Unfortunately simply executing browser refresh doesn't clear it because camo.githubusercontent.com doesn't get refreshed.