chore(deps): update circleci/browser-tools to 2.1.1 #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
Issue Update browser-tools orb to v2 (support for chrome for testing + edge browsers) #528 proposes to support Chrome for Testing and Edge browsers through
v2of the CircleCI Orb circleci/browser-toolsPR feat: Update browser-tools orb so that Chrome for testing and Edge browsers are installed in cypress/install #530 has attempted to implement this proposal, however there are multiple failures in the PR
circleci/[email protected] is the minimum version which correctly supports Chrome for Testing in addition to Edge
circleci/[email protected] included the breaking change of making all commands snake case (using underscores) replacing kebab case (using hyphens).
Change
In a first step, update the
cypress-io/circleci-orbto use circleci/[email protected] without any changes to Edge, and without attempting to add Chrome for Testing.Change usage of:
browser-tools/install-browsers-toolsto browser-tools/install_browsers_tools (snake case)Similarly, change bookmark usage to https://circleci.com/developer/orbs/orb/circleci/browser-tools#commands-install_browser_tools
Disable installation of ChromeDriver, which is not needed for Cypress. Set
install_chromedriver: false.The exposed boolean parameter
install-browsersof the following job and command is left unchanged in kebab case, avoiding producing a breaking change for Cypress Orb users:In two follow-on PRs or one combined PR, Edge can be migrated from relying on the Cypress Docker image cypress/browsers to instead use Edge installed with circleci/browser-tools and Chrome for Testing can be added.