Add CMake Project #128

podsvirov · 2016-08-03T15:41:04Z

Now implemented:

standalote installation as asio package;
optional building and installation cpp11 and cpp14 examples.

Usage standalone asio from CMake projects:

find_package(asio REQUIRED)
target_link_libraries(<target_name> asio::standalone)

Prebuid asio_cpp11_xxx and asio_cpp14_xxx examples available for testing from DaD's House by MinGW-w64 based installers:

dad-0.3.1-windows-mingw32-testing.exe

and

dad-0.3.1-windows-mingw64-testing.exe

podsvirov · 2016-08-05T03:41:15Z

Hello @chriskohlhoff,

you have the time and can see my changes?

Your library is stable, but my goal is the propaganda and popularization of the use of standalone library among the community CMake users.

podsvirov · 2016-09-11T15:12:19Z

Ping.

frozen4 · 2016-12-02T09:14:44Z

thank you! I like this

podsvirov · 2016-12-02T10:11:00Z

Great! I'm not alone :-)

podsvirov · 2016-12-24T21:41:24Z

Updated for latest master.

@frozen4 can you check it? What OS and compiler you use?

podsvirov · 2017-01-13T16:59:17Z

Hello @kdeforche! What about use this (when merged) in wt4?

podsvirov · 2017-01-25T17:10:18Z

Ping.

emweb · 2017-01-25T22:52:04Z

Hey! In wt4 we added recently an option to use non-boost asio instead of boost asio. However, as I understand it, we only need header files, and thus not really a particular build system.

Or what are you hinting at?

podsvirov · 2017-01-26T03:35:07Z

Hello @emweb!

As wrote there:

To use Asio in this way, define ASIO_STANDALONE on your compiler command line or as part of the project options.

I looked up your CMake project scripts and found no suitable instructions.

In my proposal, I create exported IMPORTED interface library asio::standalone - when you link to the target in your project, it automatically adjusts the path to the headers and define the ASIO_STANDALONE preprocessor variable.

You can check ASIO_STANDALONE definition in your C++ code to select boost or standalone Asio version and your do not need define additional custom settings variable like WT_ASIO_IS_BOOST_ASIO or WT_ASIO_IS_STANDALONE_ASIO.

(And I try link wt4 to Asio from master and it not compatible now)

@chriskohlhoff, please support our discussion.

emweb · 2017-01-26T16:30:51Z

If you want to build Wt 4 (the wt4 branch, master is still Wt 3) with the standalone version of asio, you have to set -DWT_ASIO_IMPLEMENTATION to "standalone" and set -DASIO_PREFIX correctly. I think that should be sufficient?

podsvirov · 2017-01-26T17:12:14Z

For example see config.hpp.

I think that ASIO_STANDALONE it is very important variable.

podsvirov · 2017-02-06T19:49:25Z

@chriskohlhoff, ping.

podsvirov · 2017-03-05T08:40:52Z

@chriskohlhoff, ping.

podsvirov · 2017-07-18T01:50:23Z

@chriskohlhoff, ping.

ClausKlein · 2017-07-18T20:14:56Z

Why did you not include the unit tests and the cpp03 examples?

podsvirov · 2017-07-18T21:06:13Z

Hello @ClausKlein,
at the moment, only the standalone version of the library is supported (without Boost dependencies).
As far as I know, cpp03 examples can not be built with an standalone version of the library.
The Boost library support is possible in the future, but I had to start somewhere. With something that has not happened yet (easy using standalone asio from CMake projects).
By the way, today I learned the news that the Boost library is moving to the CMake build system:
https://lists.boost.org/Archives/boost/2017/07/237248.php

ClausKlein · 2017-07-19T15:51:04Z

Hi Konstantin, based on your patch I have extended the CMakeLists.txt files to have more options and use ctest too: Claus-MBP:ninjabuild clausklein$ ninja [314/314] Linking CXX executable bin/asio_cpp14_executors_actor Claus-MBP:ninjabuild clausklein$ ctest Test project /Users/clausklein/Workspace/cpp/asio/ninjabuild Start 1: asio_unit_buffer 1/48 Test #1: asio_unit_buffer ......................... Passed 0.02 sec Start 2: asio_unit_buffered_read_stream 2/48 Test #2: asio_unit_buffered_read_stream ........... Passed 0.03 sec Start 3: asio_unit_buffered_stream 3/48 Test #3: asio_unit_buffered_stream ................ Passed 0.01 sec Start 4: asio_unit_buffered_write_stream 4/48 Test #4: asio_unit_buffered_write_stream .......... Passed 0.01 sec Start 5: asio_unit_buffers_iterator 5/48 Test #5: asio_unit_buffers_iterator ............... Passed 0.12 sec Start 6: asio_unit_coroutine 6/48 Test #6: asio_unit_coroutine ...................... Passed 0.02 sec Start 7: asio_unit_error 7/48 Test #7: asio_unit_error .......................... Passed 0.03 sec Start 8: asio_unit_generic_datagram_protocol 8/48 Test #8: asio_unit_generic_datagram_protocol ...... Passed 0.01 sec Start 9: asio_unit_generic_raw_protocol 9/48 Test #9: asio_unit_generic_raw_protocol ........... Passed 0.01 sec Start 10: asio_unit_generic_seq_packet_protocol 10/48 Test #10: asio_unit_generic_seq_packet_protocol .... Passed 0.01 sec Start 11: asio_unit_generic_stream_protocol 11/48 Test #11: asio_unit_generic_stream_protocol ........ Passed 0.01 sec Start 12: asio_unit_io_context 12/48 Test #12: asio_unit_io_context ..................... Passed 8.02 sec Start 13: asio_unit_ip_address 13/48 Test #13: asio_unit_ip_address ..................... Passed 0.01 sec Start 14: asio_unit_ip_address_v4 14/48 Test #14: asio_unit_ip_address_v4 .................. Passed 0.01 sec Start 15: asio_unit_ip_address_v6 15/48 Test #15: asio_unit_ip_address_v6 .................. Passed 0.04 sec Start 16: asio_unit_ip_host_name 16/48 Test #16: asio_unit_ip_host_name ................... Passed 0.01 sec Start 17: asio_unit_ip_icmp 17/48 Test #17: asio_unit_ip_icmp ........................ Passed 0.01 sec Start 18: asio_unit_ip_multicast 18/48 Test #18: asio_unit_ip_multicast ................... Passed 0.04 sec Start 19: asio_unit_ip_network_v4 19/48 Test #19: asio_unit_ip_network_v4 .................. Passed 0.02 sec Start 20: asio_unit_ip_network_v6 20/48 Test #20: asio_unit_ip_network_v6 .................. Passed 0.01 sec Start 21: asio_unit_ip_tcp 21/48 Test #21: asio_unit_ip_tcp ......................... Passed 0.04 sec Start 22: asio_unit_ip_udp 22/48 Test #22: asio_unit_ip_udp ......................... Passed 0.10 sec Start 23: asio_unit_ip_unicast 23/48 Test #23: asio_unit_ip_unicast ..................... Passed 0.01 sec Start 24: asio_unit_ip_v6_only 24/48 Test #24: asio_unit_ip_v6_only ..................... Passed 0.01 sec Start 25: asio_unit_is_read_buffered 25/48 Test #25: asio_unit_is_read_buffered ............... Passed 0.01 sec Start 26: asio_unit_is_write_buffered 26/48 Test #26: asio_unit_is_write_buffered .............. Passed 0.01 sec Start 27: asio_unit_local_connect_pair 27/48 Test #27: asio_unit_local_connect_pair ............. Passed 0.01 sec Start 28: asio_unit_local_datagram_protocol 28/48 Test #28: asio_unit_local_datagram_protocol ........ Passed 0.01 sec Start 29: asio_unit_local_stream_protocol 29/48 Test #29: asio_unit_local_stream_protocol .......... Passed 0.01 sec Start 30: asio_unit_posix_stream_descriptor 30/48 Test #30: asio_unit_posix_stream_descriptor ........ Passed 0.02 sec Start 31: asio_unit_read 31/48 Test #31: asio_unit_read ........................... Passed 0.03 sec Start 32: asio_unit_read_at 32/48 Test #32: asio_unit_read_at ........................ Passed 0.05 sec Start 33: asio_unit_read_until 33/48 Test #33: asio_unit_read_until ..................... Passed 0.02 sec Start 34: asio_unit_serial_port 34/48 Test #34: asio_unit_serial_port .................... Passed 0.01 sec Start 35: asio_unit_serial_port_base 35/48 Test #35: asio_unit_serial_port_base ............... Passed 0.01 sec Start 36: asio_unit_signal_set 36/48 Test #36: asio_unit_signal_set ..................... Passed 0.01 sec Start 37: asio_unit_socket_base 37/48 Test #37: asio_unit_socket_base .................... Passed 0.01 sec Start 38: asio_unit_strand 38/48 Test #38: asio_unit_strand ......................... Passed 8.03 sec Start 39: asio_unit_streambuf 39/48 Test #39: asio_unit_streambuf ...................... Passed 0.01 sec Start 40: asio_unit_system_timer 40/48 Test #40: asio_unit_system_timer ................... Passed 33.75 sec Start 41: asio_unit_use_future 41/48 Test #41: asio_unit_use_future ..................... Passed 0.02 sec Start 42: asio_unit_windows_object_handle 42/48 Test #42: asio_unit_windows_object_handle .......... Passed 0.03 sec Start 43: asio_unit_windows_overlapped_ptr 43/48 Test #43: asio_unit_windows_overlapped_ptr ......... Passed 0.02 sec Start 44: asio_unit_windows_random_access_handle 44/48 Test #44: asio_unit_windows_random_access_handle ... Passed 0.01 sec Start 45: asio_unit_windows_stream_handle 45/48 Test #45: asio_unit_windows_stream_handle .......... Passed 0.01 sec Start 46: asio_unit_write 46/48 Test #46: asio_unit_write .......................... Passed 0.04 sec Start 47: asio_unit_write_at 47/48 Test #47: asio_unit_write_at ....................... Passed 0.04 sec Start 48: asio_unit_ssl_stream 48/48 Test #48: asio_unit_ssl_stream ..................... Passed 0.04 sec 100% tests passed, 0 tests failed out of 48 Total Test time (real) = 50.92 sec Claus-MBP:ninjabuild clausklein$ It works with each option on OSX, cygwin, VC2015, but not on MSYS! I am still working on this. Regards, Claus

…

On 18 Jul 2017, at 23:06, Konstantin Podsvirov ***@***.***> wrote: Hello @ClausKlein <https://github.com/clausklein>, at the moment, only the standalone version of the library is supported (without Boost dependencies). As far as I know, cpp03 examples can not be built with an offline version of the library. The Boost library support is possible in the future, but I had to start somewhere. With something that has not happened yet (easy using standalone asio from CMake projects). By the way, today I learned the news that the Boost library is moving to the CMake build system: https://lists.boost.org/Archives/boost/2017/07/237248.php <https://lists.boost.org/Archives/boost/2017/07/237248.php> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#128 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABv4WvoJUIOQw_jCMQMlwt2WegTyo8l6ks5sPR5JgaJpZM4JbzGx>.

podsvirov · 2017-07-19T18:06:36Z

@ClausKlein, thank you for your interest and efforts.
I created these changes about a year ago, but there is still no reaction from @chriskohlhoff...

podsvirov · 2017-08-16T18:12:58Z

Rebased to master and updated list of public files to install.

podsvirov · 2017-08-17T19:35:27Z

@chriskohlhoff, any feedback please... :-(

hgaiser · 2017-11-01T10:13:39Z

What is the status of this PR? I am currently looking at workarounds but this solution would be highly preferred.

podsvirov · 2017-11-01T21:00:06Z

Rebased to master.

podsvirov · 2018-03-22T20:42:20Z

Rebased to master.

podsvirov · 2018-03-31T22:10:01Z

Hello @chriskohlhoff, what about paying attention to these changes?

podsvirov · 2018-04-01T01:42:35Z

Rebased to master.

ClausKlein · 2018-04-06T15:45:51Z

I have based on your patch conan with cmake build files prepared, see
#296

Now implemented: - standalote installation as asio package; - export asio::standalone library; - optional building and installation cpp11 and cpp14 examples; - import from buildtree.

podsvirov · 2018-06-16T07:56:05Z

Rebased to master.
Add support for import package from buildtree.

podsvirov · 2018-06-16T08:06:09Z

Dear @chriskohlhoff, what you think about CMake and about this PR?

gocarlos · 2018-12-11T14:56:50Z

@chriskohlhoff any chance this gets merged soon?

marcj · 2020-08-15T22:04:32Z

Would love to see this merged. CMake is awesome and would make integrating asio as easy as it gets. :)

gocarlos · 2020-08-16T08:42:02Z

meanwhile using asio via conan which works perfectly: https://conan.io/center/asio/1.17.0

deepbluev7 · 2020-11-12T13:01:08Z

Have you tried asking for a review on the mailing list or so? CMake support would be very useful to me!

podsvirov · 2020-11-12T13:13:54Z

Have you tried asking for a review on the mailing list or so? CMake support would be very useful to me!

No. I have not made such attempts.

@chriskohlhoff reacts on other topics, but there is silence. I think this is his principled position...

This PR make the project CMake "modern" compatible.

fakecore · 2022-05-14T17:13:21Z

What is the progress? Does there have any possibility to add CMake support?

ClausKlein · 2022-05-15T21:39:49Z

What is the progress? Does there have any possibility to add CMake support?

if you are interested on a simple header only cmake solution, you may try this: ClausKlein#3

fakecore · 2022-05-16T01:23:22Z

What is the progress? Does there have any possibility to add CMake support?

if you are interested on a simple header only cmake solution, you may try this: ClausKlein#3

Thx, I'll take a look.

robbert-vdh · 2022-06-10T11:30:24Z

Any chance of this being merged soon? Since the standalone asio doesn't come with either a simple pkgconfig file or a CMake build definition, the dependency("asio") in my Meson project can't find asio. I'll work around it by having a dedicated build option for using system asio, but this is kind of a problem when packaging software for distro repos.

leha-bot · 2022-08-31T10:33:53Z

I suggest to make a distinct repo like we made for "QR-Code-Generator" lib or pdfium and another libs for ease of packaging

hwhsu1231 · 2023-01-30T02:35:27Z

According to boostorg/cmake#24 (comment), Boost is ready to support using CMake with find_package() in CONFIG mode in release 1.82. Hope this Boost-independent Asio can do so as well.

melroy89 · 2024-01-03T14:27:37Z

@chriskohlhoff I really hope adding CMake support to this Asio library will be done in 2024.. Either via this PR or another

ClausKlein · 2024-11-29T12:42:09Z

I have an updated version here: ClausKlein#4

podsvirov force-pushed the topic-cmake-project branch from c43f226 to 0257c67 Compare December 24, 2016 21:18

podsvirov mentioned this pull request Jan 13, 2017

Release schedule #84

Open

podsvirov force-pushed the topic-cmake-project branch from 0257c67 to e789bc7 Compare August 16, 2017 18:03

podsvirov force-pushed the topic-cmake-project branch from e789bc7 to 786b53b Compare November 1, 2017 19:25

podsvirov force-pushed the topic-cmake-project branch from 786b53b to 3148ad4 Compare December 14, 2017 20:12

ClausKlein mentioned this pull request Feb 27, 2018

Add cmake build files and use ctest #286

Closed

podsvirov force-pushed the topic-cmake-project branch from 3148ad4 to 25f300c Compare March 22, 2018 20:40

podsvirov force-pushed the topic-cmake-project branch from 25f300c to 879f610 Compare April 1, 2018 01:39

Add CMake Project

741c9ec

Now implemented: - standalote installation as asio package; - export asio::standalone library; - optional building and installation cpp11 and cpp14 examples; - import from buildtree.

podsvirov force-pushed the topic-cmake-project branch from 879f610 to 741c9ec Compare June 16, 2018 07:51

podsvirov mentioned this pull request Jun 16, 2018

Add export from buildtree podsvirov/asio#1

Merged

MikeGitb mentioned this pull request Aug 25, 2018

Add CMake support #329

Closed

ClausKlein mentioned this pull request Nov 12, 2020

Feature/add cmake #420

Closed

nebatmusic pushed a commit to nebatmusic/asio that referenced this pull request Nov 16, 2020

Apply PR chriskohlhoff#128

9107155

This PR make the project CMake "modern" compatible.

podsvirov mentioned this pull request Jun 10, 2022

Add cmake/ pkg-config integration #1071

Open

Add CMake Project #128

Are you sure you want to change the base?

Add CMake Project #128

Uh oh!

Conversation

podsvirov commented Aug 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

podsvirov commented Aug 5, 2016

Uh oh!

podsvirov commented Sep 11, 2016

Uh oh!

frozen4 commented Dec 2, 2016

Uh oh!

podsvirov commented Dec 2, 2016

Uh oh!

podsvirov commented Dec 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

podsvirov commented Jan 13, 2017

Uh oh!

podsvirov commented Jan 25, 2017

Uh oh!

emweb commented Jan 25, 2017

Uh oh!

podsvirov commented Jan 26, 2017

Uh oh!

emweb commented Jan 26, 2017

Uh oh!

podsvirov commented Jan 26, 2017

Uh oh!

podsvirov commented Feb 6, 2017

Uh oh!

podsvirov commented Mar 5, 2017

Uh oh!

podsvirov commented Jul 18, 2017

Uh oh!

ClausKlein commented Jul 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

podsvirov commented Jul 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ClausKlein commented Jul 19, 2017 via email

Uh oh!

podsvirov commented Jul 19, 2017

Uh oh!

podsvirov commented Aug 16, 2017

Uh oh!

podsvirov commented Aug 17, 2017

Uh oh!

hgaiser commented Nov 1, 2017

Uh oh!

podsvirov commented Nov 1, 2017

Uh oh!

podsvirov commented Mar 22, 2018

Uh oh!

podsvirov commented Mar 31, 2018

Uh oh!

podsvirov commented Apr 1, 2018

Uh oh!

ClausKlein commented Apr 6, 2018

Uh oh!

podsvirov commented Jun 16, 2018

Uh oh!

podsvirov commented Jun 16, 2018

Uh oh!

gocarlos commented Dec 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcj commented Aug 15, 2020

Uh oh!

gocarlos commented Aug 16, 2020

Uh oh!

deepbluev7 commented Nov 12, 2020

Uh oh!

podsvirov commented Nov 12, 2020

Uh oh!

fakecore commented May 14, 2022

Uh oh!

podsvirov commented Aug 3, 2016 •

edited

Loading

podsvirov commented Dec 24, 2016 •

edited

Loading

ClausKlein commented Jul 18, 2017 •

edited

Loading

podsvirov commented Jul 18, 2017 •

edited

Loading

gocarlos commented Dec 11, 2018 •

edited

Loading