Clang's unsigned integer overflow santizer reports a runtime error when ... #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en up_heap() is called with index == 0. This error is currently harmless, since the next line short-circuits when index == 0, but it seems prudent to remove the warning, both to make Clang's sanitizer happy (remove false positive), and to make sure that the function remains safe if subsequent logic changes. Sample Clang output: /usr/include/asio/detail/timer_queue.hpp:195:33: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long'
Owner
|
Fixed in c13d36c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...up_heap()
is called with index == 0. This error is currently harmless, since the next line
short-circuits when index == 0, but it seems prudent to remove the warning, both
to make Clang's sanitizer happy (remove false positive), and to make sure that
the function remains safe if subsequent logic changes.
Sample Clang output: /usr/include/asio/detail/timer_queue.hpp:195:33: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned long'