When navigating to a calendso user that does not exist, return notFound. #2

emrysal · 2021-04-08T15:52:28Z

No description provided.

vercel · 2021-04-08T15:52:32Z

@emrysal is attempting to deploy a commit to the calendso Team on Vercel.

To accomplish this, @emrysal needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

Update profile.tsx

* second try * nit * nit

update upstream

feat: adds module transpiling so api can require @calcom/prisma

* brought api keys from admin to user level with app install * rm logs

* fix: modify error handling of incompleteBookingWriteToRecord * fix: TS error? * fix: TS error attempt #2?

* feat: Cal.ai Self Serve #2 * chore: fix import and remove logs * fix: update checkout session * fix: type errors and test * fix: imports * fix: type err * fix: type error * fix: tests * chore: save progress * fix: workflow flow * fix: workflow update bug * tests: add unit tests for retell ai webhoo * fix: status code * fix: test and delete bug * fix: add dynamic variables * fix: type err * chore: update unit test * fix: type error * chore: update default prompt * fix: type errors * fix: workflow permissions * fix: workflow page * fix: translations * feat: add call duration * chore: add booking uid * fix: button positioning * chore: update tests * chore: improvements * chore: some more improvements * refactor: improvements * refactor: code feedback * refactor: improvements * feat: enable credits for orgs (#23077) * Show credits UI for orgs * fix stripe callback url when buying credits * give orgs 20% credits * add test for calulating credits --------- Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: Udit Takkar <[email protected]> * fix: types * fix: types * chore: error * fix: type error * fix: type error * chore: mock env * feat: add idempotency key to prevent double charging * chore: add userId and teamId * fix: skip inbound calls * chore: update tests * feat: add feature flag for voice agent * feat: finish test call and other improvements * chore: add alert * chore: update .env.example * chore: improvements * fix: update tests * refactor: remove un necessary * feat: add setup badge * chore: improvements * fix: use referene id * chore: improvements * fix: type error * fix: type * refactor: change pricing logic * refactor: update tests * fix: conflicts * fix: billing link for orgs * fix: types * refactor: move feature flag up * fix: alert and test call credit check * fix: update unit tests * fix: feedback * refactor: improvements * refactor: move handlers to separate files * fix: types * fix: missing import * fix: type * refactor: change general tools functions handling * refactor: use repository * refactor: improvements * fix: types * fix: type errorr * fix: auth check * feat: add creditFor * fix: update defualt prompt * fix: throw error on frontend * fix: update unit tests * fix: use deleteAllWorkflowReminders * refactor: add connect phone number * refactor: improvements * chore: translation * chore: update message * chore: translation * design improvements buy number dialog * add translation for error message * use translation key in error message * refactor: improve connect phone number tab * feat: support un saved workflow to tests * chore: remove un used * fix: remove un used * fix: remove un used * refactor: similify billing --------- Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Keith Williams <[email protected]>

* refactor: improve _scheduleWorkflowReminders readability and add missing booking trigger events - Extract complex conditional logic into helper functions (isImmediateTrigger, isTimeBased, shouldProcessWorkflow) - Add missing workflow trigger events with immediate execution logic - Update test workflows to use different actions (EMAIL_ATTENDEE, SMS_ATTENDEE) for better differentiation - Fix translation function mock in confirm.handler.test.ts using mockNoTranslations utility - Maintain existing functionality while improving code maintainability Co-Authored-By: [email protected] <[email protected]> * only show customt emplate for form triggers * filter outside scheduleWorkflowReminder * fix type check * chore: add more tests * test: add comprehensive unit tests for handleMarkNoShow with webhook and workflow coverage - Create handleMarkNoShow.test.ts following confirm.handler.test.ts pattern - Add expectBookingNoShowUpdatedWebhookToHaveBeenFired utility function - Test both webhook and workflow triggers for BOOKING_NO_SHOW_UPDATED - Cover attendee/host no-show scenarios, multiple attendees, and error cases - All 6 unit tests pass with proper mocking of external dependencies Co-Authored-By: [email protected] <[email protected]> * Revert "test: add comprehensive unit tests for handleMarkNoShow with webhook and workflow coverage" This reverts commit 7642992. * fix: add new workflow triggers to api/v2 * update swagger docs * fix: e2e * fix type check * fix tests, add test for before after events * fix unit tests * revert confirm.handler.test * fix: unit tests * dummy form variables * add routing forms to active on dropdown * add migration file * Ui fixes for variables dropdown * remove other translation keys * review fixes * allow routing forms for activeOn * use repository function to get routing forms * remove unnecessary code * adjust logic in update handler * add triggers to api v2 * remvoe unused file * rename to getAcitveOnOptions handler * remove routingFormOptions handler * clean up getActiveOnOptions * refactor WorkflowService * remove logs * remove unused * fix: type check * fix: missed before after events for recurring * fix: calendarEvent handleMarkNoShow * fix error message Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * don't query disabled routing forms * create tasker function * add tasker code * move isFormTrigger function * small adjustments + todo comments * remove email to host action for form triggers * throw trpc error if email to host is added as step * fix dialog on how to use form responses as variables * remove add variable dropdown for form triggers * remove form workfows in event workflows tab * improvements for workflow logic on form submission * review fixes * base setup for seperate schedule functions (evt and form) * add missing BOOKING_PAID workflow trigger * fix pathname * fix: test for BOOKING_REQUESTED * fix activeOn ids * pass hideBranding and smsReminderNumber * adjustments to reminderScheduler * create empty scheduelForForm functions * pass locale and timezone with form user * pass formData instead of responses * pass timeFormat and locale * reusable function for email sending and reminder creation * implement scheduleEmailReminderForForm * remove added editor field from merge conflict * don't support cal.ai action with form triggers * throw bad request if form trigger and cal.ai is combined * add tests for scheduleFormWorkflows * add form submission tests * remove form response varibe info * clean up workflow actions * fixes for getting template options * pass triggerType to getAllWorkflows * move reusable logic to scheduleSMSReminder * add formdata to param type * type fixes for text reminder managers * implement scheduleSMSReminderForForm * fix import * fix isAuthorizedToAddActiveOnIds * disble whatsapp action * implement triggerFormSubmittedNoEventWorkflow * code clean up * Merge branch 'devin/1755107037-add-workflow-triggers' into feat/routing-form-workflow-triggers * fix type errors * remove async from getSubmitterEmail * fix type errors * revert cal.ai changes * fix type error * add sublogger * code clean up * fix type errors * remove label for attendee whatsapp action * code clean up * fixes saving teams on org workflows * fix type error * code improvements for activeOn ids * Revert "code improvements for activeOn ids" This reverts commit 0a3590a. * improve variable name * fix unit tests * small fixes * type fixes * remove unused translation keys * fix merge conflict issues * code clean up * remove SMS action support * remove more SMS code * add missing imports * set custom template for form action * type fixes * fix tasker endpoint * fix duplicate check * fix workfows.test.ts * use repository funciton to getHideBranding * code clean up * fix hasDuplicateSubmission * code clean up * select only needed properties * remove repository functions * Revert "remove repository functions" This reverts commit 7aa47b1. * add scheduleWorkflows function * Revert "add scheduleWorkflows function" This reverts commit fe5db4f. * move type to /types * Revert "move type to /types" This reverts commit 91e0152. * revert changes causing type errors * remove import * remove unused import * Revert "remove unused import" This reverts commit 1916768. * revert changed from attempt to fix type errors * pass object to gt all workflows * fix isAuthorized check * trigger filtering * remove form submitted no event booked code * remove form submitted no event from schema * remove more code * remove test * fixes * add getSubmitterEmail function * add trigger * small fixes * add missing workflow DTOs * small fixes * use activeOnWithChildren * fix active on when switching trigger type * remove add variable dropdown * add getAllWorkflowsFromRoutingForm to WorkflowService * fix error caused by undefined evt * fix type error * fix type error * fix tests * code clean up * final fixes and clean up * remove console.log * remove template text form from triggers * add routing form repoditory function * fix bug with key * fix test * add missing trigger in update-workflow.input.ts * ForEvt and ForForm function for aiPhoneCallManager * chore: add support for form workflows on api v2 * fixup! chore: add support for form workflows on api v2 * use only repository functions in update handler * move all prisma queries from list.handler * review suggestions * chore: handle workflows api v2 * chore: handle workflows api v2, split in 2 endpoints * fix workflow step creation * remove connect agent and fixes types * add type to workflow * chore: use workflow type in apiv2 WorkflowsOutputService * update worklfow type on update * chore: use workflow type in apiv2 WorkflowsOutputService * fix template body for torm trigger * some UI fixes for email subject/body * resetting email body when changing form triggers * use type field to query workflows * clean up all old active on values * remove responseId from all funciton calls * remove undefined from updateTemplate * refactor: split routing form and event-type workflows code * refactor: split routing form and event-type workflows code * fix template text when adding action * chore: don't rename WorkflowActivationDto to avoid ci blocking * refine update schedule to use only allowed actions * fix type error * don't allow whatsapp action with form trigger * fix type error * return early if activeOn array is empty * fix: from step type in BaseFormWorkflowStepDto * fixup! fix: from step type in BaseFormWorkflowStepDto * api v2 updates * move all prisma calls to repository (service/workflows.ts) * use FORM_TRIGGER_WORKFLOW_EVENTS for form queries * use userRepository * use FORM_TRIGGER_WORKFLOW_EVENTS in isFormTrigger * code clean up * code clean up * use repository functions in formSubmissionValidation.ts * add back trpc import * fix agent repository functions * remove unsued import * fixes for offset api v2 * add missing responseId * fix failing test --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: Amit Sharma <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Benny Joo <[email protected]> Co-authored-by: cal.com <[email protected]> Co-authored-by: Morgan <[email protected]>

Fixes identified issues while maintaining PR objective of removing @calcom/web dependencies from packages via dependency injection: 1. Code Duplication (Comment #2): - Extracted buildLegacyRequest to packages/lib/legacy-request.ts - Uses generic interfaces (HeadersLike, CookiesLike) instead of Next.js types - Both apps/web and packages can now import from shared location - Removed unused NextApiRequest import from calcomHandler.ts 2. Missing Cache Revalidation (Comments #3, #5, #8): - Added onInvalidate prop to NewWebhookView and wired from webhooks/new page - Added onInvalidate prop to EventWebhooksTab (needs wiring from apps/web) - Added onInvalidate prop to DuplicateDialog (needs wiring from apps/web) - Pattern: server actions with revalidatePath at call sites 3. Promise Handling Bug (Comments #6, #12): - Fixed MemberInvitationModal clipboard promise to handle rejections - Added reject handler to prevent promise hanging on mutateAsync failure Note: EventWebhooksTab and DuplicateDialog onInvalidate props are added but not yet wired from apps/web pages. This requires threading through multiple component layers and will be completed in follow-up commits. Platform DI changes (UserDropdown, PlatformMembersView, InviteMemberModal) were reverted in previous commit to prevent regressions. Co-Authored-By: Volnei Munhoz <[email protected]>

- Fix #1: Weekly schedule now shows multiple time slots per day in AvailabilityTab - Fix #2: Allow numeric input fields to be empty with proper validation - Fix #3: Add native iOS date picker for date range in Limits tab - Fix #4: Change 'Email verification' to 'Booker email verification' in Advanced tab - Fix #5: Fix Requires confirmation comparison logic in buildPartialUpdatePayload - Fix #6: Forward parameters toggle already working, verified wiring - Fix #7: Add toggles for redirect booking URL and interface language in Advanced tab - Fix #8: Increase scroll padding at bottom from 200 to 350 for better keyboard access

* fix(companion): iOS event type detail fixes - Fix #1: Weekly schedule now shows multiple time slots per day in AvailabilityTab - Fix #2: Allow numeric input fields to be empty with proper validation - Fix #3: Add native iOS date picker for date range in Limits tab - Fix #4: Change 'Email verification' to 'Booker email verification' in Advanced tab - Fix #5: Fix Requires confirmation comparison logic in buildPartialUpdatePayload - Fix #6: Forward parameters toggle already working, verified wiring - Fix #7: Add toggles for redirect booking URL and interface language in Advanced tab - Fix #8: Increase scroll padding at bottom from 200 to 350 for better keyboard access * fix(companion): conditional scroll padding for limits and advanced tabs only * fix(companion): remove static date text from iOS date picker, keep only picker * fix(companion): simplify iOS date picker to match RescheduleScreen pattern * update code

When navigating to a calendso user that does not exist, return notFound.

197ee86

pumfleet merged commit 781060e into calcom:main Apr 9, 2021

KATT added a commit that referenced this pull request Sep 3, 2021

wip - mandatory input validation (#2)

2edcf84

Herbak added a commit to Herbak/calendso that referenced this pull request Oct 14, 2021

Merge pull request calcom#2 from Herbak/Herbak-patch-1

4d15724

Update profile.tsx

mlazowik added a commit to qedsoftware/calendso that referenced this pull request Jan 6, 2022

Fix nav from team cancell to new booking, again calcom#2

f3ff5de

PeerRich mentioned this pull request Feb 20, 2022

RFC: Apps folder structure and hooks #1923

Closed

PeerRich mentioned this pull request Mar 31, 2022

RFC: advanced routing (round robin) #2330

Closed

PeerRich mentioned this pull request Jun 3, 2022

Fix/force username after signup #2549

Closed

1 task

PeerRich added a commit that referenced this pull request Jun 7, 2022

renaming "opt-in" to "requires confirmation #2 attempt (#2999)

d1cd83a

* second try * nit * nit

zomars mentioned this pull request Jun 15, 2022

v1.7 deploy #3068

Merged

emrysal added a commit that referenced this pull request Aug 16, 2022

Attempt #2: it expects regex?

2b24bff

emrysal pushed a commit that referenced this pull request Oct 30, 2022

Merge pull request #2 from calcom/main

0010106

update upstream

emrysal added a commit that referenced this pull request Feb 9, 2023

Round #2

7363265

harshmange44 mentioned this pull request Apr 17, 2023

Bookings will not send emails #8318

Closed

zomars pushed a commit that referenced this pull request May 23, 2023

Merge pull request #2 from calcom/feat/with-transpile-modules

f80f23d

feat: adds module transpiling so api can require @calcom/prisma

PeerRich added the core area: core, team members only label Jul 24, 2023

emrysal pushed a commit that referenced this pull request Aug 30, 2023

brought api keys from admin to user level with app install (#2)

7a549ae

* brought api keys from admin to user level with app install * rm logs

ciaranha mentioned this pull request Nov 14, 2023

feat: booking errors logging #12325

Merged

shazzx mentioned this pull request Nov 29, 2023

Signup options are not disabled after clicking on signup button and some other minor issues #12586

Closed

BorisKamp mentioned this pull request Jan 29, 2024

[CAL-3043] Leave site alert after filling out form and skipping confirmation after cancel on cal.com cloud #13445

Closed

AnthonyJHizon mentioned this pull request Jan 31, 2024

fix: duplicate username when inviting to team #13478

Closed

emrysal added a commit that referenced this pull request Jan 29, 2025

fix: TS error attempt #2?

e19c123

emrysal added a commit that referenced this pull request Jan 29, 2025

fix: modify error handling of incompleteBookingWriteToRecord (#18998)

b6a7a8f

* fix: modify error handling of incompleteBookingWriteToRecord * fix: TS error? * fix: TS error attempt #2?

emrysal added a commit that referenced this pull request Jan 29, 2025

fix: modify error handling of incompleteBookingWriteToRecord (#18998)

c8c19aa

* fix: modify error handling of incompleteBookingWriteToRecord * fix: TS error? * fix: TS error attempt #2?

curiousgeorgios mentioned this pull request Jul 16, 2025

fix: timezone parsing issues for calendars #21665

Merged

3 tasks

emrysal mentioned this pull request Aug 4, 2025

fix: refactor i18n loadTranslations and set timeout to 3s #22878

Merged

3 tasks

Udit-takkar added a commit that referenced this pull request Aug 9, 2025

feat: Cal.ai Self Serve #2

b0f7977

coderabbitai bot mentioned this pull request Aug 26, 2025

feat: allow emails and invite people to a team event-type #23314

Closed

anglerfishlyy mentioned this pull request Aug 30, 2025

feat: allow emails and invite people to a team event-type directly from assignment #23312

Closed

coderabbitai bot mentioned this pull request Sep 4, 2025

fix: v2 hidden event types #23584

Merged

coderabbitai bot mentioned this pull request Sep 24, 2025

feat: form submitted no event booked workflow trigger #2 #23716

Merged

devin-ai-integration bot mentioned this pull request Oct 9, 2025

fix: add users to managed event types when auto-accepting sub-team memberships #24392

Closed

3 tasks

devin-ai-integration bot mentioned this pull request Nov 4, 2025

feat: improve overlapping events display in weekly calendar view #24880

Merged

3 tasks

devin-ai-integration bot mentioned this pull request Nov 12, 2025

refactor: remove @calcom/web dependencies from packages (77 production imports fixed) #24979

Closed

7 tasks

hbjORbj mentioned this pull request Nov 22, 2025

fix: break circular dependency in messageDispatcher via dependency injection #25342

Closed

10 tasks

devin-ai-integration bot mentioned this pull request Jan 13, 2026

fix: translate location dropdown group labels and options in event-type settings #26784

Merged

8 tasks

devin-ai-integration bot mentioned this pull request Jan 16, 2026

feat(api-v2): add event-type level selected calendars for conflict checking #26730

Open

13 tasks

sean-brydon mentioned this pull request Jan 19, 2026

feat: add seat tracking infrastructure for monthly proration #27001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

When navigating to a calendso user that does not exist, return notFound. #2

When navigating to a calendso user that does not exist, return notFound. #2

Uh oh!

emrysal commented Apr 8, 2021

Uh oh!

vercel bot commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

When navigating to a calendso user that does not exist, return notFound. #2

When navigating to a calendso user that does not exist, return notFound. #2

Uh oh!

Conversation

emrysal commented Apr 8, 2021

Uh oh!

vercel bot commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants