Skip to content

Conversation

@pcrosthwaite
Copy link

  • Added an example environment file for new users to use
  • Updated the README with some additional info to help get new users up and going.

Updated the README with some additional info to help get new users up and going.
@vercel
Copy link

vercel bot commented Apr 13, 2021

Someone is attempting to deploy this pull request to the calendso Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

Copy link
Contributor

@pumfleet pumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, Peter!

@pumfleet pumfleet merged commit 44690f6 into calcom:main Apr 13, 2021
zomars pushed a commit that referenced this pull request May 23, 2023
feat: 50% almost code coverage
devin-ai-integration bot added a commit that referenced this pull request Nov 12, 2025
Fixes identified issues while maintaining PR objective of removing
@calcom/web dependencies from packages via dependency injection:

1. Code Duplication (Comment #2):
   - Extracted buildLegacyRequest to packages/lib/legacy-request.ts
   - Uses generic interfaces (HeadersLike, CookiesLike) instead of Next.js types
   - Both apps/web and packages can now import from shared location
   - Removed unused NextApiRequest import from calcomHandler.ts

2. Missing Cache Revalidation (Comments #3, #5, #8):
   - Added onInvalidate prop to NewWebhookView and wired from webhooks/new page
   - Added onInvalidate prop to EventWebhooksTab (needs wiring from apps/web)
   - Added onInvalidate prop to DuplicateDialog (needs wiring from apps/web)
   - Pattern: server actions with revalidatePath at call sites

3. Promise Handling Bug (Comments #6, #12):
   - Fixed MemberInvitationModal clipboard promise to handle rejections
   - Added reject handler to prevent promise hanging on mutateAsync failure

Note: EventWebhooksTab and DuplicateDialog onInvalidate props are added
but not yet wired from apps/web pages. This requires threading through
multiple component layers and will be completed in follow-up commits.

Platform DI changes (UserDropdown, PlatformMembersView, InviteMemberModal)
were reverted in previous commit to prevent regressions.

Co-Authored-By: Volnei Munhoz <[email protected]>
devin-ai-integration bot pushed a commit that referenced this pull request Jan 14, 2026
- Fix #1: Weekly schedule now shows multiple time slots per day in AvailabilityTab
- Fix #2: Allow numeric input fields to be empty with proper validation
- Fix #3: Add native iOS date picker for date range in Limits tab
- Fix #4: Change 'Email verification' to 'Booker email verification' in Advanced tab
- Fix #5: Fix Requires confirmation comparison logic in buildPartialUpdatePayload
- Fix #6: Forward parameters toggle already working, verified wiring
- Fix #7: Add toggles for redirect booking URL and interface language in Advanced tab
- Fix #8: Increase scroll padding at bottom from 200 to 350 for better keyboard access
dhairyashiil added a commit that referenced this pull request Jan 14, 2026
* fix(companion): iOS event type detail fixes

- Fix #1: Weekly schedule now shows multiple time slots per day in AvailabilityTab
- Fix #2: Allow numeric input fields to be empty with proper validation
- Fix #3: Add native iOS date picker for date range in Limits tab
- Fix #4: Change 'Email verification' to 'Booker email verification' in Advanced tab
- Fix #5: Fix Requires confirmation comparison logic in buildPartialUpdatePayload
- Fix #6: Forward parameters toggle already working, verified wiring
- Fix #7: Add toggles for redirect booking URL and interface language in Advanced tab
- Fix #8: Increase scroll padding at bottom from 200 to 350 for better keyboard access

* fix(companion): conditional scroll padding for limits and advanced tabs only

* fix(companion): remove static date text from iOS date picker, keep only picker

* fix(companion): simplify iOS date picker to match RescheduleScreen pattern

* update code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants