Skip to content

Conversation

@andreaestefania12
Copy link
Contributor

What does this PR do?

Fixes #2018
When you create a new account on Cal.com and you do not have username, it going to give you one with your name and some random letters. I only can tested create accounts from Prisma Data Platform.
image

Once the registration is complete you can change the username in settings.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  1. Add a new user to the team.
  2. Sign up with the new user. (This user has to be created in DB).
  3. Once the registration is complete you can see a random username.
  4. Go back to the owner team account and open view public page, booking and select any event
    image

@vercel
Copy link

vercel bot commented Apr 19, 2022

@andreaestefania12 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 3, 2022 at 3:50PM (UTC)
ui ⬜️ Ignored (Inspect) Jun 3, 2022 at 3:50PM (UTC)

Copy link
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tackling this!

Copy link
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Is this such a great idea @Jaibles?"

@ciaranha
Copy link
Member

ciaranha commented May 18, 2022

@zomars what do you think might be some better ways to handle this? The potential options I can think of (though not sure they're better are

  1. Force the person adding the team member to choose a URL (don't like)
  2. Don't create a public profile for the person until they claim the account. When they do create their account make them pick a username. (Preferred if possible)

@zomars
Copy link
Contributor

zomars commented May 18, 2022

@zomars what do you think might be some better ways to handle this? The potential options I can think of (though not sure they're better are

  1. Force the person adding the team member to choose a URL (don't like)
  2. Don't create a public profile for the person until they claim the account. When they do create their account make them pick a username. (Preferred if possible)

The latter seems like the most sensible approach. Also tagging @alannnc since he's working on in-app premium username purchase, we may add-on a "regular choose a username" to that.

@PeerRich
Copy link
Member

PeerRich commented Jun 3, 2022

@zomars what do you think might be some better ways to handle this? The potential options I can think of (though not sure they're better are

  1. Force the person adding the team member to choose a URL (don't like)
  2. Don't create a public profile for the person until they claim the account. When they do create their account make them pick a username. (Preferred if possible)

option #2 @alannnc

@PeerRich
Copy link
Member

PeerRich commented Jun 3, 2022

thank you for your contribution but we will go with option #2 from @Jaibles in a new PR 🙏

@PeerRich PeerRich closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force user to choose username after signup

6 participants