feat: add seat tracking infrastructure for monthly proration #27001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add seat change logging infrastructure with operationId for idempotency. This PR adds the foundation for monthly proration billing by tracking seat additions and removals, gated behind the monthly-proration feature flag. - Add operationId field to SeatChangeLog for idempotency - Update SeatChangeLogRepository to support upsert with operationId - Add feature flag guard in SeatChangeTrackingService - Integrate seat tracking in team member invites - Integrate seat tracking in bulk user deletions - Integrate seat tracking in team service operations - Integrate seat tracking in DSYNC user creation When monthly-proration feature flag is disabled, seat logging is skipped and behavior remains unchanged. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This was referenced Jan 19, 2026
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 12 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/trpc/server/routers/viewer/organizations/utils.ts">
<violation number="1" location="packages/trpc/server/routers/viewer/organizations/utils.ts:128">
P2: This counts seats by filtering `membershipData` for every team, which makes the new seat-tracking logic O(n^2) for bulk invites. Precompute seat counts in one pass and then map teams to counts to keep it O(n).</violation>
</file>
<file name="packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts">
<violation number="1" location="packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts:420">
P2: Pass an idempotency `operationId` into the new seat tracking calls so retries don’t double-count seat additions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Comment on lines
+128
to
+133
| const additionsByTeam = Array.from(topLevelTeamIds) | ||
| .map((teamId) => ({ | ||
| teamId, | ||
| seatCount: membershipData.filter((entry) => entry.teamId === teamId).length, | ||
| })) | ||
| .filter((entry) => entry.seatCount > 0); |
Contributor
There was a problem hiding this comment.
P2: This counts seats by filtering membershipData for every team, which makes the new seat-tracking logic O(n^2) for bulk invites. Precompute seat counts in one pass and then map teams to counts to keep it O(n).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/trpc/server/routers/viewer/organizations/utils.ts, line 128:
<comment>This counts seats by filtering `membershipData` for every team, which makes the new seat-tracking logic O(n^2) for bulk invites. Precompute seat counts in one pass and then map teams to counts to keep it O(n).</comment>
<file context>
@@ -106,6 +123,26 @@ export const addMembersToTeams = async ({ user, input }: AddBulkToTeamProps) =>
+ if (topLevelTeamIds.size > 0 && membershipData.length > 0) {
+ const seatTracker = new SeatChangeTrackingService();
+ const additionsByTeam = Array.from(topLevelTeamIds)
+ .map((teamId) => ({
+ teamId,
</file context>
Fix confidence (alpha): 8/10
Suggested change
| const additionsByTeam = Array.from(topLevelTeamIds) | |
| .map((teamId) => ({ | |
| teamId, | |
| seatCount: membershipData.filter((entry) => entry.teamId === teamId).length, | |
| })) | |
| .filter((entry) => entry.seatCount > 0); | |
| const seatCountsByTeam = membershipData.reduce((acc, { teamId }) => { | |
| acc.set(teamId, (acc.get(teamId) ?? 0) + 1); | |
| return acc; | |
| }, new Map()); | |
| const additionsByTeam = Array.from(topLevelTeamIds) | |
| .map((teamId) => ({ | |
| teamId, | |
| seatCount: seatCountsByTeam.get(teamId) ?? 0, | |
| })) | |
| .filter((entry) => entry.seatCount > 0); |
| if (createdUsers.length > 0) { | ||
| const seatTracker = new SeatChangeTrackingService(); | ||
| const trackingTeamId = parentId ?? teamId; | ||
| await seatTracker.logSeatAddition({ |
Contributor
There was a problem hiding this comment.
P2: Pass an idempotency operationId into the new seat tracking calls so retries don’t double-count seat additions.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/trpc/server/routers/viewer/teams/inviteMember/utils.ts, line 420:
<comment>Pass an idempotency `operationId` into the new seat tracking calls so retries don’t double-count seat additions.</comment>
<file context>
@@ -415,6 +413,16 @@ export async function createNewUsersConnectToOrgIfExists({
+ if (createdUsers.length > 0) {
+ const seatTracker = new SeatChangeTrackingService();
+ const trackingTeamId = parentId ?? teamId;
+ await seatTracker.logSeatAddition({
+ teamId: trackingTeamId,
+ seatCount: createdUsers.length,
</file context>
Contributor
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
Contributor
|
I reviewed the Cubic AI feedback and checked the confidence scores for each issue:
Per the guidelines to only fix issues with confidence scores of 9/10 or higher, no changes were made to this PR. Both issues are below the threshold. |
emrysal
approved these changes
Jan 19, 2026
Contributor
emrysal
left a comment
emrysal
left a comment
There was a problem hiding this comment.
I like this, looked at the cubic review and don't think it's critical for perf optimisation in this case.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of monthly proration feature.
Adds seat change tracking infrastructure with operationId for idempotency.
Dependency chain: