Merge dev into refactor#13121
Merged
TobiGr merged 76 commits intoTeamNewPipe:refactorfrom Jan 28, 2026
Merged
Conversation
onNext() is called after onSubscribe() when creating a PlayQueueAdapter. For that reason the last broadcasted event is applied to the UI state although it is already reflected in the PlayQueue that was used to initialize the adapter. This is the intended behavior of the previously used event broadcaster of the type BehaviorSubject<>. The broadcaster's type was changed to PublishSubject<> which does not emit the last event after onSubscribe(). Ref: TeamNewPipe#9669
Feat: Downloading: Add opus audio metadata tags for title, author, date, and a comment tag with the originating URL This removes the DownloadManagerService.EXTRA_SOURCE field, which is always inferred from the StreamInfo.
Ctrl+C/Ctrl+V from newpipe/local/playlist/LocalPlaylistFragment
+ some additional minor code cleanup in the file
fixes media.ccc.de kiosks
Allow dragging boorkmarked playlist in both directions
[Player] Use original audio language by default
[PlayQueue] Fix incorrect UI states of PlayQueue items
It was not deleted by mistake, delete it now Was orphaned at 1d69bd4
When resuming a download after interruption, if the server returns HTTP 200 (full resource) instead of HTTP 206 (partial content), the code correctly resets mMission.done but fails to reset the 'start' variable. This causes the subsequent file seek to use a stale offset, writing new data at incorrect positions. This bug causes file corruption for large downloads (>5GB) that are interrupted and resumed, particularly when: - Switching between WiFi networks - Server CDN returning different responses - Connection drops during long downloads The corruption manifests as duplicate data regions in the file, which for MP4 downloads results in multiple MOOV atoms and broken seek functionality. Fix: Reset start=0 when HTTP 200 is received, ensuring the file write position correctly restarts from the beginning of the current resource. (cherry picked from commit 08008ca)
…/crash-on-soundcloud-import Fix crash on screen rotation while entering SoundCloud import URL
(cherry picked from commit 23b7f21)
(cherry picked from commit a3673f8)
(cherry picked from commit 418e341)
Currently translated at 39.2% (300 of 764 strings) Translated using Weblate (Lombard) Currently translated at 0.3% (3 of 764 strings) Translated using Weblate (French) Currently translated at 75.8% (66 of 87 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Tigrinya) Currently translated at 21.8% (167 of 764 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Belarusian) Currently translated at 99.0% (757 of 764 strings) Translated using Weblate (Slovak) Currently translated at 77.0% (67 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Bulgarian) Currently translated at 3.4% (3 of 87 strings) Translated using Weblate (Santali) Currently translated at 1.1% (1 of 87 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (German) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (Turkish) Currently translated at 33.3% (29 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 78.1% (68 of 87 strings) Translated using Weblate (German) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (French) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (French) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (Czech) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (Slovak) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (Hindi) Currently translated at 77.0% (67 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 68.9% (60 of 87 strings) Co-authored-by: 135 <[email protected]> Co-authored-by: Balázs Meskó <[email protected]> Co-authored-by: Ding User <[email protected]> Co-authored-by: Dizro <[email protected]> Co-authored-by: Erenay <[email protected]> Co-authored-by: Femini <[email protected]> Co-authored-by: Fjuro <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Kuko <[email protected]> Co-authored-by: MatthieuPh <[email protected]> Co-authored-by: Mickaël Binos <[email protected]> Co-authored-by: Milan <[email protected]> Co-authored-by: Prasanta-Hembram <[email protected]> Co-authored-by: STV <[email protected]> Co-authored-by: ShareASmile <[email protected]> Co-authored-by: Sumon Kayal <[email protected]> Co-authored-by: Trunars <[email protected]> Co-authored-by: VfBFan <[email protected]> Co-authored-by: whistlingwoods <[email protected]> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/bg/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hi/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sat/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tr/ Translation: NewPipe/Metadata
Currently translated at 39.2% (300 of 764 strings) Translated using Weblate (Lombard) Currently translated at 0.3% (3 of 764 strings) Translated using Weblate (French) Currently translated at 75.8% (66 of 87 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hungarian) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Tigrinya) Currently translated at 21.8% (167 of 764 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Azerbaijani) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Belarusian) Currently translated at 99.0% (757 of 764 strings) Translated using Weblate (Slovak) Currently translated at 77.0% (67 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Bulgarian) Currently translated at 3.4% (3 of 87 strings) Translated using Weblate (Santali) Currently translated at 1.1% (1 of 87 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (German) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Hindi) Currently translated at 100.0% (764 of 764 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (Turkish) Currently translated at 33.3% (29 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 78.1% (68 of 87 strings) Translated using Weblate (German) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (French) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (French) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (Czech) Currently translated at 100.0% (87 of 87 strings) Translated using Weblate (Slovak) Currently translated at 74.7% (65 of 87 strings) Translated using Weblate (Hindi) Currently translated at 77.0% (67 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 68.9% (60 of 87 strings) Co-authored-by: 135 <[email protected]> Co-authored-by: Balázs Meskó <[email protected]> Co-authored-by: Ding User <[email protected]> Co-authored-by: Dizro <[email protected]> Co-authored-by: Erenay <[email protected]> Co-authored-by: Femini <[email protected]> Co-authored-by: Fjuro <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Kuko <[email protected]> Co-authored-by: MatthieuPh <[email protected]> Co-authored-by: Mickaël Binos <[email protected]> Co-authored-by: Milan <[email protected]> Co-authored-by: Prasanta-Hembram <[email protected]> Co-authored-by: STV <[email protected]> Co-authored-by: ShareASmile <[email protected]> Co-authored-by: Sumon Kayal <[email protected]> Co-authored-by: Trunars <[email protected]> Co-authored-by: VfBFan <[email protected]> Co-authored-by: whistlingwoods <[email protected]> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/bg/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/cs/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/hi/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sat/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/tr/ Translation: NewPipe/Metadata
Currently translated at 56.3% (49 of 87 strings) Translated using Weblate (French) Currently translated at 77.0% (67 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (764 of 764 strings) Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Mickaël Binos <[email protected]> Co-authored-by: whistlingwoods <[email protected]> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translation: NewPipe/Metadata
Currently translated at 56.3% (49 of 87 strings) Translated using Weblate (French) Currently translated at 77.0% (67 of 87 strings) Translated using Weblate (Punjabi) Currently translated at 100.0% (764 of 764 strings) Co-authored-by: Agnieszka C <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Mickaël Binos <[email protected]> Co-authored-by: whistlingwoods <[email protected]> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/ Translation: NewPipe/Metadata
Java file here because it uses kotlin function which returns non null
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
Fix and enable multiple ktlint rules
Signed-off-by: Aayush Gupta <[email protected]>
Member
Author
ShareASmile
added
meta
TobiGr
approved these changes
Jan 28, 2026
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt
Outdated
Show resolved
Hide resolved
ShareASmile
removed
ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence