Skip to content

Fix and enable multiple ktlint rules#13081

Merged
theimpulson merged 25 commits intodevfrom
ktlint
Jan 23, 2026
Merged

Fix and enable multiple ktlint rules#13081
theimpulson merged 25 commits intodevfrom
ktlint

Conversation

@theimpulson
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixes multiple ktlint rule violations and enable them

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@theimpulson theimpulson requested review from Stypox and TobiGr January 21, 2026 09:32
@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Jan 21, 2026
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
But there are conflicts that need to be fixed. Please rebase and check if the latest changes caused further ktlint violations.

@theimpulson theimpulson merged commit 460cadf into dev Jan 23, 2026
5 checks passed
@theimpulson theimpulson deleted the ktlint branch January 23, 2026 16:41
@ShareASmile ShareASmile added the codequality Improvements to the codebase to improve the code quality label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality size/giant PRs with more than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants