[PlayQueue] Fix incorrect UI states of PlayQueue items#12922
Merged
TobiGr merged 1 commit intoTeamNewPipe:release-0-28.1from Jan 7, 2026
Merged
[PlayQueue] Fix incorrect UI states of PlayQueue items#12922TobiGr merged 1 commit intoTeamNewPipe:release-0-28.1from
TobiGr merged 1 commit intoTeamNewPipe:release-0-28.1from
Conversation
TobiGr
added
GUI
onNext() is called after onSubscribe() when creating a PlayQueueAdapter. For that reason the last broadcasted event is applied to the UI state although it is already reflected in the PlayQueue that was used to initialize the adapter. This is the intended behavior of the previously used event broadcaster of the type BehaviorSubject<>. The broadcaster's type was changed to PublishSubject<> which does not emit the last event after onSubscribe(). Ref: TeamNewPipe#9669
Contributor
|
😍 I've suffered from this bug for so long! I've tested and it seems to work seamlessly |
Member
|
I've pulled and tested changes with and without the fix and can confirm it works. I want to add tests for this. Should I add them on dev or refactor? |
absurdlylongusername
approved these changes
Jan 4, 2026
6 tasks
Contributor
Author
|
I'd add the tests to dev if this part has not been touched on the refactor branch or in any of the currently open refactor PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
onNext()is called afteronSubscribe()when creating aPlayQueueAdapter. For that reason the last broadcasted event is applied to the UI state although it is already reflected in the PlayQueue that was used to initialize the adapter.This is the intended behavior of the previously used event broadcaster of the type
BehaviorSubject<>. The broadcaster's type was changed toPublishSubject<>which does not emit the last event afteronSubscribe().Before/After Screenshots/Screen Record
For screen records of the bugged behaviour, see #9669
Screen_recording_20251220_181830.webm
Review request
Help me identify why a
BehaviorSubjectwas used in the first place. Is there a place where its functionality is needed?Fixes the following issue(s)
Fixes #9669
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence