Fix crash on screen rotation while entering SoundCloud import URL

[siddhesh-06]

What is it?

• Bugfix (user facing)

Description of the changes in your PR

• Fixed the below IllegalStateException

• Preserved the service Intent across configuration changes (e.g. screen rotation)
• Ensured the dialog safely restores its state after recreation
• Prevented null access when the dialog is recreated by the system

Before/After Screenshots/Screen Record

• Before:

before-fix.mp4

• After:

after-fix.mp4

Fixes the following issue(s)

• Fixes UI error crash when rotating screen while typing url to import soundcloud file #11914

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.
• The proposed changes follow the AI policy.
• I tested the changes using an emulator or a physical device.

[TobiGr]

LGTM, are we able to remove the state now? At least I do not see areason to keep it now.
remove-state.patch

diff --git a/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java b/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java
index b586ad3..0054bd2 100644
--- a/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java
+++ b/app/src/main/java/org/schabi/newpipe/local/subscription/ImportConfirmationDialog.java
@@ -10,13 +10,11 @@ import androidx.appcompat.app.AlertDialog;
 import androidx.fragment.app.DialogFragment;
 import androidx.fragment.app.Fragment;
 
-import com.evernote.android.state.State;
 import com.livefront.bridge.Bridge;
 
 import org.schabi.newpipe.R;
 
 public class ImportConfirmationDialog extends DialogFragment {
-    @State
     protected Intent resultServiceIntent;
     private static final String EXTRA_RESULT_SERVICE_INTENT = "extra_result_service_intent";
 
@@ -48,10 +46,7 @@ public class ImportConfirmationDialog extends DialogFragment {
     @Override
     public void onCreate(@Nullable final Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-
         resultServiceIntent = requireArguments().getParcelable(EXTRA_RESULT_SERVICE_INTENT);
-
-        Bridge.restoreInstanceState(this, savedInstanceState);
     }
 
     @Override

[TobiGr]

thank you!

[TobiGr]

/backport release-0-28.1

[github-actions]

Successfully created backport PR for release-0-28.1:

• [Backport release-0-28.1] Fix crash on screen rotation while entering SoundCloud import URL #13029