Remove unused dependencies and methods#153
Merged
apbendi merged 1 commit intoens-resolver-upgrade-implementationfrom Apr 5, 2021
Merged
Remove unused dependencies and methods#153apbendi merged 1 commit intoens-resolver-upgrade-implementationfrom
apbendi merged 1 commit intoens-resolver-upgrade-implementationfrom
Conversation
Contributor
|
seems like this doesn't help much judging from lockfile. Well, since ethers.js wants to include noble in the next version (ethers-io/ethers.js#727, twitter), I think you'll see the real pkg size difference right after that. |
Collaborator
Author
|
Yea ended up being a small change. Since it's a monorepo, a good portion of the lockfile comes from dependencies of the fronted + contracts workspaces too, so elliptic and it's dependencies likely won't be removed from lockfile anytime soon. But they still should be tree-shaken out of the production umbra-js bundle, though I haven't looked into that yet |
mds1
force-pushed
the
remove-dependencies
branch
from
382e3b1 to
b2b0ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
(branched off #151, so figured we can just merge this into 151's branch first since this will be a much quicker PR to review/merge)