Conversation
|
Getting the following error trying to go through the setup flow with a new ENS name:
EDIT: resolved with |
apbendi
left a comment
apbendi
left a comment
There was a problem hiding this comment.
Looks great! Everything seems to work fine with no hiccups. Awesome work. I tried to put it t through all the various scenarios and it seemed to respond correctly. A couple of minor UX things:
In the scenario where the user is not using the Public Resolver, it might be nice to include a link to the record in question to the ENS app, namely: https://app.ens.domains/name/$DOMAIN.eth
"Don't worry, this will not break anything!" Haha this sounds a git ominous. Maybe say something like, "the rest of your ENS configuration will be carried over, and you'll be able to continue using ENS like normal" or something along those lines? I'd also consider bolding "You'll now be asked to sign 3 transactions"
Gas used for three steps for me:
setAuthorisation: 47,709
setStealthKeys: 84,265
setResolver: 31,203
That's 163,177 in total, or about $40 at current prices. Not great, but not as awful as I'd feared.
- Carousel is no longer swipeable - Link user to their ENS name on the ENS app to configure it - Change phrasing / add bold text on the 3 tx setup step
|
Implemented the changes above, so merging now |
2 participants
Closes #113
Everything should be working, but admittedly there's a bit of complexity and lots of checks to this flow, so there may still be some bugs for edge cases—please test thoroughly!