Skip to content

Remove unused dependencies and methods #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apbendi merged 1 commit into from
Apr 5, 2021
Merged

Remove unused dependencies and methods #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions umbra-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
"license": "ISC",
"dependencies": {
"@unstoppabledomains/resolution": "1.20.0",
"bn.js": "^5.1.3",
"buffer": "^6.0.2",
"dotenv": "^8.2.0",
"ethers": "^5.0.25",
"noble-secp256k1": "^1.1.2"
},
Expand All @@ -35,6 +32,7 @@
"@types/mocha": "^8.0.4",
"@umbra/contracts": "^0.0.1",
"chai": "^4.2.0",
"dotenv": "^8.2.0",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-chai-friendly": "^0.6.0",
"eslint-plugin-import": "^2.20.2",
Expand Down
10 changes: 1 addition & 9 deletions umbra-js/src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import { Signature, recoverPublicKey } from 'noble-secp256k1';
import { Contract, ContractInterface } from 'ethers';
import { arrayify, Bytes, Hexable, isHexString, splitSignature } from '@ethersproject/bytes';
import { isHexString, splitSignature } from '@ethersproject/bytes';
import { keccak256 } from '@ethersproject/keccak256';
import { resolveProperties } from '@ethersproject/properties';
import { EtherscanProvider } from '@ethersproject/providers';
Expand All @@ -21,14 +21,6 @@ export const lengths = {
publicKey: 132, // 64 bytes + 0x04 prefix
};

/**
* @notice Convert hex string with 0x prefix into Buffer
* @param value Hex string to convert
*/
export function hexStringToBuffer(value: string | number | Bytes | Hexable) {
return Buffer.from(arrayify(value));
}

/**
* @notice Given a transaction hash, return the public key of the transaction's sender
* @dev See https://github.com/ethers-io/ethers.js/issues/700 for an example of
Expand Down
9 changes: 7 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5865,7 +5865,7 @@ buffer-xor@^2.0.1:
dependencies:
safe-buffer "^5.1.1"

[email protected], buffer@^6.0.2:
[email protected]:
version "6.0.3"
resolved "https://registry.yarnpkg.com/buffer/-/buffer-6.0.3.tgz#2ace578459cc8fbe2a70aaa8f52ee63b6a74c6c6"
integrity sha512-FTiCpNxtwiZZHEZbcbTIcZjERVICn9yq/pDFkTl95/AxzD1naBctN7YO68riM/gLSDY7sdrMby8hofADYuuqOA==
Expand Down Expand Up @@ -21155,7 +21155,12 @@ xtend@~2.1.1:
dependencies:
object-keys "~0.4.0"

y18n@^3.2.1, y18n@^4.0.0, y18n@^4.0.1:
y18n@^3.2.1:
version "3.2.2"
resolved "https://registry.yarnpkg.com/y18n/-/y18n-3.2.2.tgz#85c901bd6470ce71fc4bb723ad209b70f7f28696"
integrity sha512-uGZHXkHnhF0XeeAPgnKfPv1bgKAYyVvmNL1xlKsPYZPaIHxGti2hHqvOCQv71XMsLxu1QjergkqogUnms5D3YQ==

y18n@^4.0.0:
version "4.0.1"
resolved "https://registry.yarnpkg.com/y18n/-/y18n-4.0.1.tgz#8db2b83c31c5d75099bb890b23f3094891e247d4"
integrity sha512-wNcy4NvjMYL8gogWWYAO7ZFWFfHcbdbE57tZO8e4cbpj8tfUcwrwqSl3ad8HxpYWCdXcJUCeKKZS62Av1affwQ==
Expand Down