✨ Prepare pallets for async backing

[dastansam]

What?

Introduces BlockNumberProvider type for pallets

Why?

So that we can use a more reliable, consistent notion of block number, since with async backing system block number becomes nondeterministic

How?

Relay chain's block number is used where possible, i.e funding, linear-release, and we rely on system block number in other cases

Testing?

Changes were made to Instantiator so that it works for both integration and unit tests, since now integration tests Runtime uses relay chain's block number instead of chain's

Screenshots (optional)

Anything Else?

#469

[dastansam]

• 🏗️ Vesting pallet block number provider migration #474 : 2 dependent PRs (#476 , #478 )
• 🏗️ Linear release block number provider migration #473
• 🏗️ Funding pallet migration for enabling async backing #472
• ✨ Prepare pallets for async backing #471 👈 (View in Graphite)
• ⬆️ Upgrade to Polkadot SDK stable2412-2 #470
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (03/14/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

[lrazovic]

Just 2 nits, but the approach seems straightforward!

[lrazovic]

Isn't this also part of the use super::*; two lines below?

[dastansam]

ah, that's because the type is ambiguous here. there is BlockNumberFor in the frame_system::pallet_prelude::* as well

[Copilot]

Pull Request Overview

This PR updates several pallets and related tests to use a unified notion of block number via the new BlockNumberProvider type, enabling more reliable async backing.

• Replaces direct calls to frame_system’s block_number with BlockNumberProvider::current_block_number.
• Adds BlockNumberProvider implementations and configurations in TestRuntime, mocks, and integration tests.
• Updates Cargo.toml dependencies to include necessary cumulus pallets to support asynchronous backing.

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pallets/funding/src/mock.rs	Updated system config and added ParachainSystem configuration.
pallets/funding/src/lib.rs	Replaced frame_system block_number calls with BlockNumberProvider calls.
pallets/funding/src/instantiator/*	Updated type bounds and block number calls to incorporate BlockNumberProvider.
pallets/funding/src/functions/*	Uniformly replaced block_number retrieval methods.
pallets/democracy/*	Switched to using BlockNumberProvider in multiple block number checks.
integration-tests/*	Adjusted integration tests to reference the relay chain’s block number provider.

Comments suppressed due to low confidence (2)

pallets/funding/src/instantiator/chain_interactions.rs:177

• [nitpick] This workaround uses frame_system::Pallet's set_block_number instead of a corresponding method from BlockNumberProvider. Consider unifying block number setting under BlockNumberProvider if a proper method becomes available.

self.execute(|| { frame_system::Pallet::<T>::set_block_number(block - One::one()); });

integration-tests/src/tests/e2e.rs:586

• [nitpick] The change from PolimecSystem to PolkadotSystem for retrieving the block number may lead to inconsistencies. Verify that using PolkadotSystem here is intentional and consistent with the overall use of BlockNumberProvider in production code.

let now = PolkadotSystem::block_number();

[lrazovic]

Merge activity

• May 2, 7:23 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• May 2, 7:24 AM EDT: Graphite rebased this pull request as part of a merge.
• May 2, 7:25 AM EDT: @lrazovic merged this pull request with Graphite.