Conversation
dastansam
force-pushed
the
03-14-use_type
branch
3 times, most recently
from
5d5cb33 to
52283eb
Compare
dastansam
force-pushed
the
03-14-use_type
branch
from
52283eb to
6306557
Compare
Contributor
Author
|
closed in favor of #471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Introduces
BlockNumberProvidertype for palletsWhy?
So that we can use a more reliable, consistent notion of block number, since with async backing system block number becomes nondeterministic
How?
Relay chain's block number is used where possible, i.e funding, linear-release, and we rely on system block number in other cases
Testing?
Changes were made to
Instantiatorso that it works for both integration and unit tests, since now integration tests Runtime uses relay chain's block number instead of chain'sScreenshots (optional)
Anything Else?
#469