Conversation
This was referenced Apr 25, 2025
Member
Author
lrazovic
force-pushed
the
04-25-allow_transact
branch
5 times, most recently
from
9328d1e to
762e004
Compare
dastansam
changed the base branch from
03-21-vesting_pallet_block_number_provider_migration
to
graphite-base/477
lrazovic
force-pushed
the
04-25-allow_transact
branch
from
762e004 to
fa8c284
Compare
lrazovic
changed the base branch from
graphite-base/477
to
03-21-vesting_pallet_block_number_provider_migration
lrazovic
changed the base branch from
03-21-vesting_pallet_block_number_provider_migration
to
graphite-base/477
lrazovic
force-pushed
the
04-25-allow_transact
branch
from
fa8c284 to
cd5c5d0
Compare
lrazovic
changed the base branch from
graphite-base/477
to
04-29-migrate_pallet_staking_to_use_new_block_time
Graphite Automations"Auto-assign PRs to author" took an action on this PR • (04/30/25)1 assignee was added to this PR based on Juan Ignacio Rios's automation. |
dastansam
force-pushed
the
04-25-allow_transact
branch
from
cd5c5d0 to
f87b89e
Compare
lrazovic
force-pushed
the
04-29-migrate_pallet_staking_to_use_new_block_time
branch
from
3c99aa6 to
c5e9fda
Compare
lrazovic
force-pushed
the
04-25-allow_transact
branch
2 times, most recently
from
cd5c5d0 to
9c675e8
Compare
dastansam
reviewed
May 1, 2025
| } | ||
| /// Allows messages starting with DescendOrigin(AccountId32) from AssetHub | ||
| /// followed immediately by BuyExecution. | ||
| pub struct AllowPaidDescendFromAssetHub; |
Contributor
There was a problem hiding this comment.
not critical, but we could add some unit tests for this. maybe ask gemini
| // ^ Disable dispatchable execute on the XCM pallet. | ||
| // Needs to be `Everything` for local testing. | ||
| type WeightInfo = crate::weights::pallet_xcm::WeightInfo<Runtime>; | ||
| type XcmExecuteFilter = Everything; |
Contributor
There was a problem hiding this comment.
is this needed? this is for local xcm execution, right?
Merged
lrazovic
force-pushed
the
04-25-allow_transact
branch
from
9c675e8 to
f61bdd5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables XCM Transact by updating various chain and node configurations, revising XCM parameters, and adjusting auto-generated weights. Key changes include:
- Updating the chain specification and node configuration (e.g. changing chain names, port settings, and adding validator flags).
- Modifying XCM barrier and origin configurations (e.g. changing SafeCallFilter to allow Transact instructions and updating origin conversions).
- Refreshing auto-generated weight values and adjusting related chain spec settings.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/zombienet/polimec-polkadot-assethub-penpal.toml | Updated relaychain chain name, port settings, node validator flags, and commented out hrmp_channels. |
| runtimes/polimec/src/xcm_config.rs | Revised XCM configuration including origin conversion, barrier settings, and SafeCallFilter semantics. |
| runtimes/polimec/src/weights/pallet_xcm.rs | Updated auto-generated weights based on new benchmarks. |
| runtimes/polimec/src/lib.rs | Removed mocked channel info and updated asset transfer destination configuration. |
| nodes/parachain/src/chain_spec/* | Adjusted chain spec parameters including stakers list and safeXcmVersion wrapping. |
| runtimes/polimec/build.rs | Introduced multiple wasm builder configurations for production and test builds. |
dastansam
force-pushed
the
04-25-allow_transact
branch
from
f61bdd5 to
9d1634a
Compare
dastansam
force-pushed
the
04-29-migrate_pallet_staking_to_use_new_block_time
branch
from
c5e9fda to
3c99aa6
Compare
lrazovic
force-pushed
the
04-25-allow_transact
branch
from
9d1634a to
f61bdd5
Compare
lrazovic
force-pushed
the
04-29-migrate_pallet_staking_to_use_new_block_time
branch
from
3c99aa6 to
c5e9fda
Compare
Member
Author
lrazovic
changed the base branch from
04-29-migrate_pallet_staking_to_use_new_block_time
to
graphite-base/477
lrazovic
force-pushed
the
04-25-allow_transact
branch
from
f61bdd5 to
5a35905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XCM and Runtime Enhancements:
send,teleport_assets, andtransfer_assets. These changes improve accuracy and reflect the current runtime performance. [1] [2] [3] [4]reachable_destandteleportable_asset_and_destmethods.Executelocal XCM messages.Transacton Polomec via XCM messages.Genesis Configuration Updates:
safeXcmVersionfield in the genesis configuration to use anOptiontype, allowing for better flexibility in initialization.charlie, to the list of initial stakers in the Polimec Paseo chain specification.Weight and Benchmark Updates:
pallet_linear_releasemodule for runtime weights and updated theWeightInfoimplementation to use a centralizedweightsmodule for consistency. [1] [2]pallet_xcmmodule for weights and updated benchmarks to include additional storage reads/writes and execution time adjustments. [1] [2]Code Cleanup and Refactoring:
MockedChannelInfostruct and related logic, as it is no longer needed after upgradingpallet-xcm. This simplifies the runtime configuration.fast-mode).These changes collectively improve the runtime's performance, maintainability, and compatibility with the latest Substrate updates.