Conversation
9 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dastansam
changed the title
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
4 times, most recently
from
ba2441f to
fcf9ede
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
e07c1a9 to
cbc803c
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
2 times, most recently
from
9b6d309 to
16119cf
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
cbc803c to
4317213
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
2 times, most recently
from
3a47582 to
257656a
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
2 times, most recently
from
8c9017b to
d1e02ed
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
3 times, most recently
from
3ec3366 to
c5c8e08
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
2 times, most recently
from
b5ae21f to
7c4f030
Compare
This was referenced Mar 21, 2025
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
d1e02ed to
699d4da
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
7c4f030 to
4d70109
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the funding pallet to support asynchronous backing by updating the storage migration paths and introducing a new vesting info migration.
- Updated migration paths in polimec runtime to reflect new module structure.
- Added a new vesting info migration (v7 to v8) to adapt vesting times for a faster block time.
- Refactored funding pallet storage migration module and updated storage version reference.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| runtimes/polimec/src/lib.rs | Updated migration paths to the new module structure and added vesting info migration. |
| pallets/funding/src/migrations/vesting_info.rs | Introduced new vesting info migration with runtime upgrade hooks and tests. |
| pallets/funding/src/migrations/storage_migrations.rs | Refactored import statements and removed redundant storage version constant. |
| pallets/funding/src/migrations/mod.rs | Created a centralized module file with the current storage version. |
| pallets/funding/src/lib.rs | Updated pallet attribute to reference the new migration module. |
Comments suppressed due to low confidence (1)
pallets/funding/src/migrations/vesting_info.rs:1
- [nitpick] The file header comment incorrectly references 'storage_migrations.rs' instead of 'vesting_info.rs', which may cause confusion. Please update the comment to accurately reflect the file's purpose.
// storage_migrations.rs
4d70109 to
a4226b4
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
f4e4f84 to
e8ccde4
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
a4226b4 to
ce89017
Compare
lrazovic
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
ce89017 to
cfcee7a
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
e8ccde4 to
6ab4ec1
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
cfcee7a to
ea3bfe1
Compare
dastansam
force-pushed
the
03-14-prepare_pallets_for_async_backing
branch
from
6ab4ec1 to
e087f8f
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
ea3bfe1 to
4bdace6
Compare
lrazovic
approved these changes
Apr 11, 2025
lrazovic
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4bdace6 to
4858afd
Compare
Merged
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4858afd to
4bdace6
Compare
lrazovic
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4bdace6 to
4858afd
Compare
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4858afd to
4bdace6
Compare
lrazovic
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4bdace6 to
4858afd
Compare
Merged
lrazovic
changed the title
dastansam
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4858afd to
4bdace6
Compare
lrazovic
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4bdace6 to
4858afd
Compare
lrazovic
changed the base branch from
03-14-prepare_pallets_for_async_backing
to
graphite-base/472
lrazovic
force-pushed
the
03-14-migrated_pallet_funding_for_block_number_provider
branch
from
4858afd to
94b245d
Compare
lrazovic
deleted the
03-14-migrated_pallet_funding_for_block_number_provider
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
migrates UserMigrations to use relay chain block number, assuming change from 12s block time to 6s. Tested with try-runtime and a unit test
Why?
How?
Testing?
Screenshots (optional)
Anything Else?