Merged
Conversation
Member
|
Might be good to note that seasons end when champs end in the PR template. |
ec1648d to
d8a955f
Compare
Member
Author
|
Done. |
mcm001
reviewed
Jan 26, 2026
Co-authored-by: Matt Morley <[email protected]>
mcm001
previously approved these changes
Jan 26, 2026
samfreund
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All comments are now uncommented to encourage people to actually delete them because they kept getting into commit descriptions and it's annoying. Also tried to make a more convincing argument for collecting test evidence to nudge people into testing and recording the results of that test to help with verifying PR functionality, as what the author has or has not tested is often unclear (and more often than not, edge cases were not tested, which is how #2227 was made.)
This also clarifies that the description should contain info about the events that led to a PR. What event led to that line being added? There happened to be discussion on the FRC Discord about vendordeps compiling against the WPILib kickoff release, which prompted discussion about PV's version locking implemented in #1772, but we couldn't ascertain why #1772 was made (which has since been edited to include that info) given the guarantees given by Gradle and so we had to trudge through Discord to figure out the events triggering that PR, then created #2307 in response (which also contains links and additional context for future readers.)
Finally, the line about settings compatibility has been future-proofed to always require compatibility to the previous season's releases, and to say "all" because of the events leading up to #2331. Seasons end when Champs ends.
Meta
Merge checklist: