-
Notifications
You must be signed in to change notification settings - Fork 296
Update PR template #2334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−5
Merged
Update PR template #2334
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,18 @@ | ||
| ## Description | ||
|
|
||
| <!-- What changed? Why? (the code + comments should speak for itself on the "how") --> | ||
| What changed? Why? (the code + comments should speak for itself on the "how") | ||
|
|
||
| <!-- Fun screenshots or a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. --> | ||
| Fun screenshots or a cool video or something are super helpful as well. If this touches core/platform-specific behavior, this is where test evidence should be collected. Test evidence is important to establish feature functionality. | ||
|
|
||
| <!-- Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. --> | ||
| Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. | ||
|
|
||
| ## Meta | ||
|
|
||
| Merge checklist: | ||
| - [ ] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes | ||
| - [ ] The description documents the _what_ and _why_ | ||
| - [ ] The description documents the _what_ and _why_, including events that led to this PR | ||
| - [ ] If this PR changes behavior or adds a feature, user documentation is updated | ||
| - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly | ||
| - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 | ||
| - [ ] If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends) | ||
| - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated | ||
| - [ ] If this PR addresses a bug, a regression test for it is added | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.