Verify WPILib/OpenCV versions at runtime#1772
Merged
mcm001 merged 4 commits intoPhotonVision:mainfrom Feb 11, 2025
Merged
Conversation
Contributor
Author
|
CC @Gold856 |
Member
|
Oh, and link #1770 so it gets closed when the PR is merged. |
| TimeSyncSingleton.load(); | ||
|
|
||
| // HACK - check if things are compatible | ||
| verifyDependencies(); |
Member
There was a problem hiding this comment.
Do we want to do this in C++ and Python as well?
Contributor
Author
There was a problem hiding this comment.
Ggezwp. Yeah. But this gets us 80% of the way there.
Member
There was a problem hiding this comment.
lol, I'll open a follow up for you
samdev-7
pushed a commit
to Earl-Of-March-FRC/photonvision
that referenced
this pull request
Feb 16, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1770
https://discordapp.com/channels/725836368059826228/725848198794706994/1330965087800004631
A user was depending on a version of Photon that needed OpenCV 4.10, but an old Monologue was on opencv 4.8
The easiest way to prevent this is a strict version pin, but this is perhaps overzealous