Restore original dashboard view behavior #2227
Merged
samfreund merged 2 commits intoPhotonVision:mainfrom Dec 7, 2025
Merged
Conversation
samfreund
approved these changes
Dec 7, 2025
samfreund
pushed a commit
to samfreund/photonvision
that referenced
this pull request
Dec 18, 2025
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#2168 removed a
v-iffrom the camera activation modal, which prevents the dialog from disappearing when cameras are activated on the backend with no other input from the user. That PR also misunderstood how to fix comparisons against thePlaceholderCameraSettingsobject. Because the object was reactive state due to it being inCameraSettingsStore, the comparison would always fail because it was comparing a reactive proxy to the original object, which never equals true. This uses the solution provided by the Vue docs, which is to wrap the whole object inreactive()so that accessing it is consistent.Meta
Merge checklist: