Skip to content

Only update UI when there's been a change in conflict detection#2054

Merged
Gold856 merged 2 commits intoPhotonVision:mainfrom
Gold856:selectively-update-ui
Aug 11, 2025
Merged

Only update UI when there's been a change in conflict detection#2054
Gold856 merged 2 commits intoPhotonVision:mainfrom
Gold856:selectively-update-ui

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Aug 11, 2025

Description

After #1991, the program state was always resent in an attempt to simplify logic, but this had the side effect of causing the settings UI to reset periodically when the hostname check was performed. This restores the original logic in #1791 to check for differences in the conflict state, and to only send the program state if it's changed.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner August 11, 2025 03:42
@Gold856 Gold856 linked an issue Aug 11, 2025 that may be closed by this pull request
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 11, 2025
samfreund
samfreund previously approved these changes Aug 11, 2025
@Gold856 Gold856 merged commit b32d9c6 into PhotonVision:main Aug 11, 2025
42 checks passed
@Gold856 Gold856 deleted the selectively-update-ui branch August 14, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend resets new values in Global Settings before they can be saved

2 participants