Skip to content

Only update UI when there's been a change in conflict detection #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gold856 merged 2 commits into from
Aug 11, 2025
Merged

Only update UI when there's been a change in conflict detection #2054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f308df6
Only update UI when there's been a change in conflict detection
Gold856 Aug 11, 2025
1c7e76f
This is why the author should test their stuff first
Gold856 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions ...re/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,20 +300,21 @@ private void checkHostnameAndCameraNames() {
}
}

// Publish the conflict status
DataChangeService.getInstance()
.publishEvent(
new OutgoingUIEvent<>(
"fullsettings",
UIPhotonConfiguration.programStateToUi(ConfigManager.getInstance().getConfig())));

conflictAlert.setText(
conflictingHostname
? "Hostname conflict detected for " + hostname + "!"
: ""
+ (conflictingCameras.isEmpty()
? ""
: " Camera name conflict detected: " + conflictingCameras.toString() + "!"));
if (conflictingHostname != this.conflictingHostname
|| !conflictingCameras.toString().equals(this.conflictingCameras)) {
// Only publish the conflict status when it's changed to prevent the settings cards from being
// forcibly reset
DataChangeService.getInstance()
.publishEvent(
new OutgoingUIEvent<>(
"fullsettings",
UIPhotonConfiguration.programStateToUi(ConfigManager.getInstance().getConfig())));
}
if (conflictingHostname) {
conflictAlert.setText("Hostname conflict detected for " + hostname + "!");
} else if (!conflictingCameras.isEmpty()) {
conflictAlert.setText("Camera name conflict detected: " + conflictingCameras + "!");
}
conflictAlert.set(conflictingHostname || !conflictingCameras.isEmpty());
SmartDashboard.updateValues();
this.conflictingHostname = conflictingHostname;
Expand Down
Loading