Refactor MAC address detection#1991
Merged
samfreund merged 3 commits intoPhotonVision:mainfrom Jul 13, 2025
Merged
Conversation
Member
|
Looks good, I'll test and confirm when I have time. |
samfreund
approved these changes
Jul 13, 2025
7 tasks
Gold856
added a commit
that referenced
this pull request
Aug 11, 2025
## Description After #1991, the program state was always resent in an attempt to simplify logic, but this had the side effect of causing the settings UI to reset periodically when the hostname check was performed. This restores the original logic in #1791 to check for differences in the conflict state, and to only send the program state if it's changed. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MAC address detection didn't work on devices where PhotonVision doesn't manage the networking, as the logic pulled the interface name from the config. It also repeatedly spammed the logs with messages, which is super annoying and makes the logs harder to navigate. The system has been modified to use Java's NetworkInterface class to find a network interface on devices where PhotonVision doesn't manage networking, and the extra debug log has been removed since it doesn't tell us any information.
Resolves #1990.
Meta
Merge checklist: