feat: add metrics publisher for NT#1791
Merged
Gold856 merged 25 commits intoPhotonVision:mainfrom Jul 12, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mcm001
reviewed
Feb 19, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
mcm001
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
2432619 to
ee9d7ed
Compare
Contributor
|
Refactored to publish a protobuf, not sure if this actually better but |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
5630f52 to
fa708a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
2 times, most recently
from
ecbda3a to
cded102
Compare
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
2 times, most recently
from
d1f1409 to
5f5f274
Compare
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
5f5f274 to
33dddf3
Compare
Gold856
requested changes
Jul 12, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
2 times, most recently
from
7f712e8 to
55319e1
Compare
Gold856
requested changes
Jul 12, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Outdated
Show resolved
Hide resolved
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
e342c60 to
56aadeb
Compare
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
56aadeb to
71b5843
Compare
samfreund
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
71b5843 to
0ac0f39
Compare
Gold856
previously approved these changes
Jul 12, 2025
Gold856
previously approved these changes
Jul 12, 2025
Gold856
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
ede2f6d to
d7941a7
Compare
Gold856
force-pushed
the
feat-publish-coprocessor-metrics
branch
from
d7941a7 to
9b79cf0
Compare
Gold856
approved these changes
Jul 12, 2025
7 tasks
Gold856
added a commit
that referenced
this pull request
Aug 11, 2025
## Description After #1991, the program state was always resent in an attempt to simplify logic, but this had the side effect of causing the settings UI to reset periodically when the hostname check was performed. This restores the original logic in #1791 to check for differences in the conflict state, and to only send the program state if it's changed. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes metrics to NT using a protobuf under
photonvision/coprocessors/metricsusing the device host name as the key.Refactors metrics to use numbers where possible, instead of strings.
Removes metrics from card when they can't be determined for platform.
Updates UI metrics periodically.
Resolves #1988
Closes #830