Skip to content

despam log message#1990

Closed
samfreund wants to merge 2 commits intoPhotonVision:mainfrom
samfreund:deconflict-host-camera-names
Closed

despam log message#1990
samfreund wants to merge 2 commits intoPhotonVision:mainfrom
samfreund:deconflict-host-camera-names

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Jul 4, 2025

Description

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner July 4, 2025 22:30
@Gold856
Copy link
Member

Gold856 commented Jul 5, 2025

It feels weird to keep the exact contents of that message and put it in that new spot. Can we reword it?

@samfreund samfreund force-pushed the deconflict-host-camera-names branch from a167c1b to 1fc6964 Compare July 5, 2025 17:54
@Gold856
Copy link
Member

Gold856 commented Jul 6, 2025

Can we also avoid spamming the error message when a MAC address can't be found?

@samfreund
Copy link
Member Author

Can we also avoid spamming the error message when a MAC address can't be found?

We could, but I feel this is a significant enough error that we should be spamming it. I also don't see a case where the MAC address can't be found per se, given that in order to connect to the device it rather needs one.

@Gold856
Copy link
Member

Gold856 commented Jul 6, 2025

The error is spammed repeatedly on my Windows laptop. It makes it very annoying to read log messages.

@Gold856 Gold856 mentioned this pull request Jul 6, 2025
7 tasks
@samfreund samfreund closed this Jul 11, 2025
@samfreund samfreund deleted the deconflict-host-camera-names branch July 13, 2025 18:00
@Gold856 Gold856 added the backend Things relating to photon-core and photon-server label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants