Closed
Conversation
Member
|
It feels weird to keep the exact contents of that message and put it in that new spot. Can we reword it? |
a167c1b to
1fc6964
Compare
Member
|
Can we also avoid spamming the error message when a MAC address can't be found? |
Member
Author
We could, but I feel this is a significant enough error that we should be spamming it. I also don't see a case where the MAC address can't be found per se, given that in order to connect to the device it rather needs one. |
Member
|
The error is spammed repeatedly on my Windows laptop. It makes it very annoying to read log messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Meta
Merge checklist: