fix preprocess script with processbar, integrity check and logs#16608
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Apr 2, 2019
Merged
fix preprocess script with processbar, integrity check and logs#16608luotao1 merged 2 commits intoPaddlePaddle:developfrom
luotao1 merged 2 commits intoPaddlePaddle:developfrom
Conversation
Contributor
Author
|
@kbinias @bingyanghuang @Sand3r- @luotao1 Please review this new PR rebased on release 1.4. (old one closed). Thank you |
lidanqing-vv
force-pushed
the
lidanqing/preprocess_after1.4
branch
from
d36db51 to
18555af
Compare
lidanqing-vv
force-pushed
the
lidanqing/preprocess_after1.4
branch
from
18555af to
06d35a7
Compare
lidanqing-vv
commented
Apr 1, 2019
kbinias
reviewed
Apr 1, 2019
Contributor
kbinias
left a comment
kbinias
left a comment
There was a problem hiding this comment.
I checked this code on my developer machine, the expected result is binary file.
Contributor
|
The log is very nice, thanks very much! |
luotao1
approved these changes
Apr 2, 2019
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
Please cherry-pick to release/1.4, and note that the commit info should have test=release/1.4.
yihuaxu
pushed a commit
to yihuaxu/Paddle
that referenced
this pull request
Apr 2, 2019
…lePaddle#16608) test=release/1.4 * fix preprocess script with processbar, integrity check and logs * delete unnecessary empty lines, change function name
yihuaxu
pushed a commit
to yihuaxu/Paddle
that referenced
this pull request
Apr 2, 2019
…lePaddle#16608) test=release/1.4 * fix preprocess script with processbar, integrity check and logs * delete unnecessary empty lines, change function name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reviews of PR 16529, rebased on release 1.4