Review fix for PR 16529 preprocess with PIL the full val dataset and save binary #16562
Closed
lidanqing-vv wants to merge 1 commit intoPaddlePaddle:developfrom
Closed
Review fix for PR 16529 preprocess with PIL the full val dataset and save binary #16562lidanqing-vv wants to merge 1 commit intoPaddlePaddle:developfrom
lidanqing-vv wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
lidanqing-vv
changed the title
Contributor
Author
|
@luotao1 I will use checksum and md5 for this completeness of file. I am working on it now |
Contributor
|
@bingyanghuang Could you help review it? |
Contributor
There was a problem hiding this comment.
The log info is too long and too confused. Maybe you can change it to "Start to convert jpg to binary file, the file will contain images and labels data"
Contributor
There was a problem hiding this comment.
Please add "Start download Full ImageNet Validation dataset" before starting download the dataset, remove the print on line 109 and line 114.
lidanqing-vv
force-pushed
the
lidanqing/full-preprocess-extend
branch
from
402762d to
12d16cd
Compare
Contributor
Author
|
New PR 16608 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reviews of PR 16529
Review:
unzip not inplace Done
Print hard to understand Done
Print logging every 500 images Done
Existing file integrity Done