Merged
Conversation
Signed-off-by: Dengjianping <djptux@gmail.com>
This was referenced Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
Contributor
Author
|
In this PR, we must rewrite rpc part for manta-pay with jsonrpsee. And there's a comment we should be careful |
13 tasks
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
reviewed
Jul 12, 2022
Garandor
previously approved these changes
Jul 12, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
added 14 commits
July 12, 2022 10:12
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Contributor
|
Pls resolve this comment the PR here: |
Signed-off-by: Adam Reif <Garandor@manta.network>
ghzlatarev
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dengjianping djptux@gmail.com
Description
closes: #538
closes: #379
closes: #390
Substrate:
v0.9.18 -> v0.9.19
benchmark-storageflags: Additionalbenchmark-storageflags paritytech/substrate#11004dev_getblockstatsrpc: Adddev_getBlockStatsRPC paritytech/substrate#10939benchmark-blockcommand: Addbenchmark-blockcommand paritytech/substrate#11091wasm: Change default execution strategies toWasmparitytech/substrate#11170benchmark: Sub-commands forbenchmarkparitytech/substrate#11164seal_delegate_call: contracts: Stabilizeseal_delegate_callparitytech/substrate#11037seal_code_hashandseal_own_code_hash: contracts: addseal_code_hashandseal_own_code_hashto API paritytech/substrate#10933weighttofeepolynomials to `pallet_transaction_payment...: ApplyWeightToFeePolynomials topallet_transaction_payment's length fee paritytech/substrate#10785v0.9.19 -> v0.9.20
benchmark machine: Addbenchmark machineparitytech/substrate#11198v0.9.20 -> v0.9.21:
v0.9.21 -> v0.9.22
chain-infosubcommand: Addchain-infoSubcommand paritytech/substrate#11250--unsafe-pruningcli-argument (step 1): Remove the--unsafe-pruningCLI-argument (step 1) paritytech/substrate#10995frame_support::crypto::ecdsa::public.to_eth_address(): Addframe_support::crypto::ecdsa::Public.to_eth_address()(k256-based) and use it in pallets paritytech/substrate#11087Polkadot:
v0.9.18 -> v0.9.19
v0.9.19 -> v0.9.20
benchmark machinecommand: Co #11198: Exposebenchmark machinecommand paritytech/polkadot#5326v0.9.20 -> v0.9.21
dispute-coordinatormessage burstiness handling paritytech/polkadot#5471v0.9.21 -> v0.9.22
Cumuls:
v0.9.18 -> v0.9.19
benchmark: Co #11164: Sub-commands forbenchmarkparitytech/cumulus#1156benchmark: Co #11164: Sub-commands forbenchmarkparitytech/cumulus#1156benchmark machinecommand: Co #11198: Exposebenchmark machinecommand paritytech/cumulus#1172ParachainHostin Polkadot: Handle relocation ofParachainHostin Polkadot paritytech/cumulus#1108v0.9.19 -> v0.9.20
v0.9.20 -> v0.9.21
v0.9.21 -> v0.9.22
Manta
use cumulus_primitives_core::relay_chain::v1=>use cumulus_primitives_core::{relay_chain::v2See both PRs: [Companion for primitives consolidation into v2](Companion for primitives consolidation into v2 paritytech/cumulus#1071) and [Finish migration to v2 primitives](Finish migration to v2 primitives paritytech/polkadot#5037)
construct_benchmark_partialswhich is used for benchmark:See this PR: Sub-commands for
benchmark#![allow(clippy::unnecessary_cast)]josnrpsee.mantaPay_pull_ledger_difffrom manta-pay asblocking.https://github.com/Manta-Network/Manta/pull/571/files#diff-ada1b74d9d0e41a7bc44d9d3ef17a29cb751ef83d034424adcb6c3a671f6c1a5
match_typewithmatch_types, the previous one is going to be deprecated.errorinDispatchErrorbecome fromu32to[u8; 4]. Be careful with this change, it will reflect on front-end.See this PR: Allow pallet error enum variants to contain fields paritytech/substrate#10242
https://github.com/Manta-Network/Manta/pull/571/files#diff-3287a4ee060b1070a8e6559a094b4890a596a1b281effef54cafe59da20edf49R60
LengthToFeetopallet_transaction_payment.See this PR: Apply
WeightToFeePolynomials topallet_transaction_payment's length fee paritytech/substrate#10785Note: I suppose
transaction_versionwill be bumped.polkadot_runtime_common.benchmark:=>
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.mdFiles changedin the Github PR explorer.authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.ymlworkflow for help. If this number is updated, then thespec_versionmust also be updatedBaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.