Add force_batch to utility pallet by jasl · Pull Request #11148 · paritytech/substrate

jasl · 2022-03-31T20:16:47Z

Add force_batch to utility pallet which is useful for you wanna batch a bunch of calls that some of them may failed but failed can be ignored.

polkadot address: 13asnZw4BnT2dsTYU4YTm3GMXySF6ocNov96493SPMNrVd2c
polkadot companion: paritytech/polkadot#5452

ggwpez · 2022-04-02T11:17:26Z

Very cool! You already have this deployed on the Khala testnet, right? For what are you using it, if I may ask?
A cargo +nightly fmt is needed for the CI and we need to re-benchmark it.

The code is very close the the original batch extrinsic. Any general ideas on this @bkchr, @shawntabrizi ?
PS: Does this break the API?

jasl · 2022-04-02T22:21:27Z

Very cool! You already have this deployed on the Khala testnet, right? For what are you using it, if I may ask? A cargo +nightly fmt is needed for the CI and we need to re-benchmark it.

The code is very close the the original batch extrinsic. Any general ideas on this @bkchr, @shawntabrizi ? PS: Does this break the API?

I forgot to click "comment" 😄

You already have this deployed on the Khala testnet, right?

Yes! we use this for a long time, I forgot to contribute to Substrate...

For what are you using it

We have serveral usecase, for example:

Khala chain is a control plane for off-chain workers (aka pruntime or miner), so people will group control their workers, some of miners already stopped or can't start for some reason (e.g. stake isn't enough), so some of calls fail is OKay for users, just pick those failed and retry
Workers should respond messages, they will submit their responses to the chain, sometimes workers duplicate respond a message, it's OK, and we don't want other responses drop

A cargo +nightly fmt is needed for the CI and we need to re-benchmark it.

Done

Overrall, this is another version of batch, now we have 3 types of batch:

batch run calls until meets an error
batch_all like transaction that all calls should success
batch_try run calls and don't care error

bkchr · 2022-04-02T22:25:36Z

The naming isn't great. Try implies that you try to execute something and bail on an error. So, this naming would fit better to the original dispatchable. We should rename the new one to convey its implementation details better to the user.

jasl · 2022-04-02T22:27:45Z

The naming isn't great. Try implies that you try to execute something and bail on an error. So, this naming would fit better to the original dispatchable. We should rename the new one to convey its implementation details better to the user.

could you give a suggest? it's should useful for batch a bunch of discrate calls, we also not satisfied its naming, but I don't have better idea.

kianenigma

Code seems to look fine, but I would call this force_batch, since you are forcing the execution of all calls, even if one fails?

bkchr · 2022-04-04T10:01:41Z

force_batch sounds good to me :)

jasl · 2022-04-04T12:57:07Z

Name changed.

ggwpez

I will put this in the audit queue soon, will probably take a while.

frame/utility/src/lib.rs

shawntabrizi

This looks reasonable to me.

frame/utility/src/lib.rs

kianenigma

Should await audit.

frame/utility/src/lib.rs

Co-authored-by: Louis Merlin <hello@louismerl.in>

cla-bot-2021 · 2022-04-28T15:42:32Z

User @louismerlin, please sign the CLA here.

jasl · 2022-05-04T18:33:41Z

could you give me some direction?

We just need to add the weight info for that extrinsic since it is already deployed on Polkadot. It would probably be enough to open an "empty" companion MR and then call the bench bot. There is an explanation here https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#updating-polkadot-as-well

Understood, thank you, I'll do this tomorrow

jasl · 2022-05-04T20:37:54Z

@bkchr companion added.

shawntabrizi · 2022-05-04T21:54:24Z

bot merge

paritytech-processbot · 2022-05-04T21:54:31Z

Error: "Check reviews" status is not passing for paritytech/polkadot#5452

shawntabrizi · 2022-05-04T21:54:49Z

@jasl if you would like a small tip in KSM or DOT, please include your address in the PR description.

bkchr · 2022-05-04T23:13:05Z

bot merge

paritytech-processbot · 2022-05-04T23:13:12Z

Error: "Check reviews" status is not passing for paritytech/polkadot#5452

jasl · 2022-05-05T08:14:38Z

@jasl if you would like a small tip in KSM or DOT, please include your address in the PR description.

wow thanks!

jasl · 2022-05-05T08:25:57Z

bot merge

maybe I do things wrong...

follow the guide (https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#updating-polkadot-as-well) I've done step 1 - 5

use diener patch --crates-to-patch ../substrate --substrate to patch Polkadot, so the PR includes patch dependencies redirect to my local folder.

bkchr · 2022-05-05T10:39:29Z

bot merge

paritytech-processbot · 2022-05-05T10:39:36Z

Error: "Check reviews" status is not passing for paritytech/polkadot#5452

bkchr · 2022-05-05T10:39:47Z

/tip small

substrate-tip-bot · 2022-05-05T10:39:51Z

A small tip was successfully submitted for jasl (13asnZw4BnT2dsTYU4YTm3GMXySF6ocNov96493SPMNrVd2c on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips

bkchr · 2022-05-05T10:41:40Z

bot merge

paritytech-processbot · 2022-05-05T10:41:46Z

Error: "Check reviews" status is not passing for paritytech/polkadot#5452

bkchr · 2022-05-05T10:44:06Z

bot merge

* Add batch_try to utility pallet * lint * rename utility.batch_try -> utility.force_batch * Remove un-needed index field for utility.ItemFailed event * Remove indexes of utility,BatchCompletedWithErrors * Apply suggestions from code review Co-authored-by: Louis Merlin <hello@louismerl.in> Co-authored-by: Louis Merlin <hello@louismerl.in> Co-authored-by: Bastian Köcher <info@kchr.de>

Add batch_try to utility pallet

424a84c

ggwpez added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 2, 2022

lint

225bb84

kianenigma reviewed Apr 4, 2022

View reviewed changes

rename utility.batch_try -> utility.force_batch

2f3df99

jasl changed the title ~~Add batch_try to utility pallet~~ Add force_batch to utility pallet Apr 4, 2022

ggwpez reviewed Apr 4, 2022

View reviewed changes

frame/utility/src/lib.rs Outdated Show resolved Hide resolved

frame/utility/src/lib.rs Outdated Show resolved Hide resolved

Remove un-needed index field for utility.ItemFailed event

e5a7a56

shawntabrizi approved these changes Apr 5, 2022

View reviewed changes

bkchr approved these changes Apr 6, 2022

View reviewed changes

frame/utility/src/lib.rs Outdated Show resolved Hide resolved

jasl force-pushed the port-batch_try branch from c010b8e to 456387a Compare April 6, 2022 10:36

Remove indexes of utility,BatchCompletedWithErrors

c1141ca

jasl force-pushed the port-batch_try branch from 456387a to c1141ca Compare April 6, 2022 10:37

kianenigma reviewed Apr 8, 2022

View reviewed changes

kianenigma removed the A0-please_review Pull request needs code review. label Apr 16, 2022

louismerlin reviewed Apr 28, 2022

View reviewed changes

frame/utility/src/lib.rs Outdated Show resolved Hide resolved

Apply suggestions from code review

7a3863c

Co-authored-by: Louis Merlin <hello@louismerl.in>

bkchr added 2 commits May 4, 2022 13:43

Merge remote-tracking branch 'origin/master' into port-batch_try

433bed8

Merge remote-tracking branch 'origin/master' into port-batch_try

219d752

bkchr removed the D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited label May 4, 2022

Merge remote-tracking branch 'origin/master' into port-batch_try

0ca3085

jasl mentioned this pull request May 4, 2022

Companion for substrate#11148 paritytech/polkadot#5452

Merged

shawntabrizi mentioned this pull request May 4, 2022

Companion for Force Batch paritytech/cumulus#1236

Merged

paritytech-processbot bot merged commit f996a3a into paritytech:master May 5, 2022

jasl deleted the port-batch_try branch May 5, 2022 12:29

joao-paulo-parity mentioned this pull request May 5, 2022

check_dependent_project: retrigger once the PR description changes paritytech/pipeline-scripts#37

Closed

jasl mentioned this pull request May 23, 2022

Upgrade to Polkadot v0.9.22 Phala-Network/khala-parachain#109

Merged

github-actions bot mentioned this pull request May 31, 2022

Update substrate/polkadot/cumulus from v0.9.20 to v0.9.22 moonbeam-foundation/moonbeam#1557

Closed

github-actions bot mentioned this pull request Jun 22, 2022

Update substrate/polkadot/cumulus from v0.9.20 to v0.9.23 moonbeam-foundation/moonbeam#1623

Closed

Dengjianping mentioned this pull request Jul 7, 2022

Bump deps to v0.9.22 Manta-Network/Manta#571

Merged

10 tasks

ghzlatarev mentioned this pull request Jul 29, 2022

Update deps from v0.9.22 to v0.9.26 Manta-Network/Manta#720

Merged

3 tasks

Conversation

jasl commented Mar 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ggwpez commented Apr 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasl commented Apr 2, 2022

Uh oh!

bkchr commented Apr 2, 2022

Uh oh!

jasl commented Apr 2, 2022

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

bkchr commented Apr 4, 2022

Uh oh!

jasl commented Apr 4, 2022

Uh oh!

ggwpez left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shawntabrizi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kianenigma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cla-bot-2021 bot commented Apr 28, 2022

Uh oh!

jasl commented May 4, 2022

Uh oh!

jasl commented May 4, 2022

Uh oh!

shawntabrizi commented May 4, 2022

Uh oh!

paritytech-processbot bot commented May 4, 2022

Uh oh!

shawntabrizi commented May 4, 2022

Uh oh!

bkchr commented May 4, 2022

Uh oh!

paritytech-processbot bot commented May 4, 2022

Uh oh!

jasl commented May 5, 2022

Uh oh!

jasl commented May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr commented May 5, 2022

Uh oh!

paritytech-processbot bot commented May 5, 2022

Uh oh!

bkchr commented May 5, 2022

Uh oh!

substrate-tip-bot bot commented May 5, 2022

Uh oh!

bkchr commented May 5, 2022

Uh oh!

paritytech-processbot bot commented May 5, 2022

Uh oh!

bkchr commented May 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jasl commented Mar 31, 2022 •

edited

Loading

ggwpez commented Apr 2, 2022 •

edited

Loading

ggwpez left a comment •

edited

Loading

jasl commented May 5, 2022 •

edited

Loading