This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
Contributor
Author
|
I've fully removed v0 and will remove v1 next (this one will get a bit tedious :) ) |
ordian
reviewed
Mar 7, 2022
ordian
reviewed
Mar 7, 2022
Contributor
Author
|
@ordian At some point we should be able to remove the storage migration and the |
ordian
approved these changes
Mar 7, 2022
Contributor
Author
|
@sandreim is going to test on Versi & ZombieNet, and then we can merge 🎉 |
Contributor
|
Tested on Versi and ZombieNet and did not see any issues with parachain block production. I have observed some errors and warnings:
|
Contributor
Author
|
Neither of those seem related. Thank you for testing @sandreim |
Member
|
I think the cumulus companion did not merge, so cumulus does currently not build with polkadot master. |
10 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4803
Closes #4802
This removes v0 and v1 primitives, migrating everything to v2 instead. This also adds a
RuntimeApiRequest::Version(currently, the runtime API subsystem handles versions internally, but it'd be better for that to be handled at the subsystem level after doing high-level version checks).cumulus companion: paritytech/cumulus#1071