Add a bounded fallback on failed elections by georgesdib · Pull Request #10988 · paritytech/substrate

georgesdib · 2022-03-06T20:31:51Z

Change the Fallback type to be InstantElectionProvider.
In node runtime, have a bounded fallback instead of no fallback.

Polkadot companion: paritytech/polkadot#5093
skip check-dependent-cumulus

Polkadot address: 131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4

PSA: Update Guide

This is not a breaking change, but we advice all chains to update their election config accordingly, specially for test-networks, to make sure a fallback exists to recover from errors.

solutions, issue #9478

Removing a seemingly outdated comment

Co-authored-by: Kian Paimani <[email protected]>

And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]>

Some cleanups

solutions, issue #9478

Removing a seemingly outdated comment

Co-authored-by: Kian Paimani <[email protected]>

And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]>

Some cleanups

…strate into election-fallback

frame/election-provider-support/src/onchain.rs

frame/support/src/traits/misc.rs

bin/node/runtime/src/lib.rs

frame/election-provider-support/src/onchain.rs

feedback from kian

kianenigma · 2022-03-22T15:30:07Z

/tip medium

substrate-tip-bot · 2022-03-22T15:30:09Z

Please fix the following problems before calling the tip bot again:

Invalid command! Payload should be: "/tip { small / medium / large }".

kianenigma · 2022-03-22T15:30:34Z

/tip medium

substrate-tip-bot · 2022-03-22T15:30:38Z

A medium tip was successfully submitted for georgesdib (131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4 on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

kianenigma · 2022-03-25T04:59:05Z

bot merge

paritytech-processbot · 2022-03-25T04:59:12Z

Error: Github API says paritytech/polkadot#5093 is not mergeable

kianenigma · 2022-03-25T05:03:06Z

bot merge

paritytech-processbot · 2022-03-25T05:03:16Z

Error: Checks failed for f816a67

kianenigma · 2022-03-25T20:01:06Z

bot merge

paritytech-processbot · 2022-03-25T20:01:17Z

Error: Checks failed for f816a67

kianenigma · 2022-03-25T20:15:39Z

bot merge

kianenigma · 2022-03-25T20:15:46Z

finallyyyyyy bot, finally.

@kianenigma

* Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Merging types into one type with generics * Removing `ConstUSize` and use `ConstU32` * cleaning up the code * deprecating `OnChainSequentialPhragmen` Renaming it to `UnboundedSequentialPhragmen` which should only be used at genesis and for testing. Use preferrably `BoundedOnChainSequentialPhragmen` * Amending docs * Adding some explicit imports * Implementing generic `BoundedOnchainExecution` Removing the deprecated `OnChainSequentialPhragmen` * Use the right Balancing strategy * Refactoring `onchain::Config` Creating `onchain::ExecutionConfig` * Merge master * fmt * Name cleanups after review suggestions * cosmetics * renaming `instant_elect` to `elect_with_bounds` Other corresponding changes as per @kianenigma feedback * `BoundedOnchainExecution` -> `BoundedExecution` And `UnboundedOnchainExecution` -> `UnboundedExecution` * feedback from kian * fmt + unneeded import Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: kianenigma <[email protected]>

@kianenigma

* Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Merging types into one type with generics * Removing `ConstUSize` and use `ConstU32` * cleaning up the code * deprecating `OnChainSequentialPhragmen` Renaming it to `UnboundedSequentialPhragmen` which should only be used at genesis and for testing. Use preferrably `BoundedOnChainSequentialPhragmen` * Amending docs * Adding some explicit imports * Implementing generic `BoundedOnchainExecution` Removing the deprecated `OnChainSequentialPhragmen` * Use the right Balancing strategy * Refactoring `onchain::Config` Creating `onchain::ExecutionConfig` * Merge master * fmt * Name cleanups after review suggestions * cosmetics * renaming `instant_elect` to `elect_with_bounds` Other corresponding changes as per @kianenigma feedback * `BoundedOnchainExecution` -> `BoundedExecution` And `UnboundedOnchainExecution` -> `UnboundedExecution` * feedback from kian * fmt + unneeded import Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: kianenigma <[email protected]>

@kianenigma

* Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Merging types into one type with generics * Removing `ConstUSize` and use `ConstU32` * cleaning up the code * deprecating `OnChainSequentialPhragmen` Renaming it to `UnboundedSequentialPhragmen` which should only be used at genesis and for testing. Use preferrably `BoundedOnChainSequentialPhragmen` * Amending docs * Adding some explicit imports * Implementing generic `BoundedOnchainExecution` Removing the deprecated `OnChainSequentialPhragmen` * Use the right Balancing strategy * Refactoring `onchain::Config` Creating `onchain::ExecutionConfig` * Merge master * fmt * Name cleanups after review suggestions * cosmetics * renaming `instant_elect` to `elect_with_bounds` Other corresponding changes as per @kianenigma feedback * `BoundedOnchainExecution` -> `BoundedExecution` And `UnboundedOnchainExecution` -> `UnboundedExecution` * feedback from kian * fmt + unneeded import Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: kianenigma <[email protected]>

@kianenigma

* Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Merging types into one type with generics * Removing `ConstUSize` and use `ConstU32` * cleaning up the code * deprecating `OnChainSequentialPhragmen` Renaming it to `UnboundedSequentialPhragmen` which should only be used at genesis and for testing. Use preferrably `BoundedOnChainSequentialPhragmen` * Amending docs * Adding some explicit imports * Implementing generic `BoundedOnchainExecution` Removing the deprecated `OnChainSequentialPhragmen` * Use the right Balancing strategy * Refactoring `onchain::Config` Creating `onchain::ExecutionConfig` * Merge master * fmt * Name cleanups after review suggestions * cosmetics * renaming `instant_elect` to `elect_with_bounds` Other corresponding changes as per @kianenigma feedback * `BoundedOnchainExecution` -> `BoundedExecution` And `UnboundedOnchainExecution` -> `UnboundedExecution` * feedback from kian * fmt + unneeded import Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: kianenigma <[email protected]>

@kianenigma

* Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Allow `pallet-election-provider` to accept smaller solutions, issue paritytech#9478 * Fixing a typo * Adding some more tests Removing a seemingly outdated comment * making it a URL * Updating test name as per suggestion Co-authored-by: Kian Paimani <[email protected]> * Updating documentation to be more explicit And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]> * Fixing formatting * `Fallback` now of type `InstantElectionProvider` Some cleanups * Merging types into one type with generics * Removing `ConstUSize` and use `ConstU32` * cleaning up the code * deprecating `OnChainSequentialPhragmen` Renaming it to `UnboundedSequentialPhragmen` which should only be used at genesis and for testing. Use preferrably `BoundedOnChainSequentialPhragmen` * Amending docs * Adding some explicit imports * Implementing generic `BoundedOnchainExecution` Removing the deprecated `OnChainSequentialPhragmen` * Use the right Balancing strategy * Refactoring `onchain::Config` Creating `onchain::ExecutionConfig` * Merge master * fmt * Name cleanups after review suggestions * cosmetics * renaming `instant_elect` to `elect_with_bounds` Other corresponding changes as per @kianenigma feedback * `BoundedOnchainExecution` -> `BoundedExecution` And `UnboundedOnchainExecution` -> `UnboundedExecution` * feedback from kian * fmt + unneeded import Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: kianenigma <[email protected]>

Georges Dib and others added 19 commits February 23, 2022 21:03

Allow pallet-election-provider to accept smaller

922f655

solutions, issue #9478

Fixing a typo

5e63199

Adding some more tests

d0177c0

Removing a seemingly outdated comment

making it a URL

46de469

Updating test name as per suggestion

6ad51ab

Co-authored-by: Kian Paimani <[email protected]>

Updating documentation to be more explicit

0506bd1

And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]>

Fixing formatting

a604cea

Fallback now of type InstantElectionProvider

a7bf404

Some cleanups

Allow pallet-election-provider to accept smaller

8f3e8b4

solutions, issue #9478

Fixing a typo

80ce9cb

Adding some more tests

1960035

Removing a seemingly outdated comment

making it a URL

3f87102

Updating test name as per suggestion

f683841

Co-authored-by: Kian Paimani <[email protected]>

Updating documentation to be more explicit

3e3752f

And to follow the general guidelines Co-authored-by: Kian Paimani <[email protected]>

Fixing formatting

521e4d2

Fallback now of type InstantElectionProvider

d94ac40

Some cleanups

Merge branch 'election-fallback' of https://github.com/georgesdib/sub…

d389ee3

…strate into election-fallback

Merging types into one type with generics

6e8c419

Merge upstream into current branch

de45d73

georgesdib requested a review from kianenigma as a code owner March 6, 2022 20:31

kianenigma requested a review from emostov March 8, 2022 14:27

kianenigma added A0-please_review Pull request needs code review. B7-runtimenoteworthy D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited C1-low PR touches the given topic and has a low impact on builders. labels Mar 8, 2022

shawntabrizi reviewed Mar 8, 2022

View reviewed changes

frame/election-provider-support/src/onchain.rs Outdated Show resolved Hide resolved

shawntabrizi reviewed Mar 8, 2022

View reviewed changes

frame/support/src/traits/misc.rs Outdated Show resolved Hide resolved

Removing ConstUSize and use ConstU32

47dc9ef

kianenigma reviewed Mar 9, 2022

View reviewed changes

bin/node/runtime/src/lib.rs Outdated Show resolved Hide resolved

emostov reviewed Mar 9, 2022

View reviewed changes

frame/election-provider-support/src/onchain.rs Outdated Show resolved Hide resolved

kianenigma and others added 2 commits March 21, 2022 10:25

feedback from kian

762966f

Merge pull request #47 from georgesdib/kiz-election-fallback

5aae3e2

feedback from kian

emostov approved these changes Mar 21, 2022

View reviewed changes

fmt + unneeded import

ae86c59

Merge branch 'master' into election-fallback

f816a67

paritytech-processbot bot merged commit 69079b5 into paritytech:master Mar 25, 2022

georgesdib deleted the election-fallback branch March 25, 2022 20:19

github-actions bot mentioned this pull request Apr 20, 2022

Update substrate/polkadot/cumulus from v0.9.18 to v0.9.19 moonbeam-foundation/moonbeam#1428

Closed

jakoblell added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 8, 2022

Dengjianping mentioned this pull request Jul 7, 2022

Bump deps to v0.9.22 Manta-Network/Manta#571

Merged

10 tasks

github-actions bot mentioned this pull request Jul 18, 2022

Update substrate/polkadot/cumulus from v0.9.18 to v0.9.19 imstar15/moonbeam#1

Open

MRamanenkau mentioned this pull request Oct 26, 2022

Feature/update to polkadot v0 9 19 Cerebellum-Network/pos-network-node#184

Merged

Conversation

georgesdib commented Mar 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PSA: Update Guide

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kianenigma commented Mar 22, 2022

Uh oh!

substrate-tip-bot bot commented Mar 22, 2022

Uh oh!

kianenigma commented Mar 22, 2022

Uh oh!

substrate-tip-bot bot commented Mar 22, 2022

Uh oh!

kianenigma commented Mar 25, 2022

Uh oh!

paritytech-processbot bot commented Mar 25, 2022

Uh oh!

kianenigma commented Mar 25, 2022

Uh oh!

paritytech-processbot bot commented Mar 25, 2022

Uh oh!

kianenigma commented Mar 25, 2022

Uh oh!

paritytech-processbot bot commented Mar 25, 2022

Uh oh!

kianenigma commented Mar 25, 2022

Uh oh!

kianenigma commented Mar 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

georgesdib commented Mar 6, 2022 •

edited

Loading