Add preconfirmation signature verification to tx status manager #2856

MitchTurner · 2025-03-11T20:25:28Z

Linked Issues/PRs

Description

Adds generic logic to the tx status manager task to accept delegate keys and check signatures with them.

The logic of actually tracking the delegate keys and doing verification is behind the SignatureVerification trait, which will be implemented in a follow-up PR.

Checklist

New behavior is reflected in tests

Before requesting review

I have reviewed the code myself

…their delegate key

…ure-verification-2

AurelienFT

Nice I like the implementation !

…ure-verification-2

crates/services/tx_status_manager/src/tests/mod.rs

crates/services/tx_status_manager/src/service.rs

xgreenx · 2025-03-12T20:47:18Z

crates/services/tx_status_manager/src/service.rs

+                } else {
+                    // TODO: Allow to retry later when a new delegate key is added
+                    tracing::warn!("Preconfirmation signature verification failed, will try once more when a new delegate key is added");
+                    self.early_preconfirmations.push(sealed);
+                }


I think we should ignore these preconfirmations, otherwise anyone can spam the node with invalid preconfirmations until node OOM, before it processes a new DelegateKey event.

We are going to lose some preconfirmations then probably. It's an edge case, but if delegations happen at the same time as the pre-confirmations it's bound to happen.

It is fine if you are a new in the network. But if you running for some time, it shouldn't happen

+1, even if it can be annoying for tests, maybe keep it under test-helpers

There is no situation where the delegate key signature could come after something signed by the delegate key?

(I've already implemented the TODO, I just forgot to remove it)

It can arrive, but it is fine to ignore, because maybe this key doesn't exist

I feel like ideally we handle that with reputation, but I'll remove it for now and leave a note.

Yes, here we need to decrease the reputation of the peer in the case if he tries to spam us with invalid reconfirmations. But it should a follow up=)

xgreenx · 2025-03-12T20:53:39Z

crates/services/tx_status_manager/src/service.rs

-    fn new_preconfirmations_from_p2p(
+#[allow(dead_code)]
+/// Interface for signature verification of preconfirmations
+pub trait SignatureVerification: Send {


It should be in the ports if you want to define its implementation outside of the service crate.

But I think it is an overkill to do it via the port. Because you already expect concrete types from the p2p, so you already know what signature types do you expect.

If you plan to abstract the signature types in the future, then yeah, it makes sense, but for not it looks like an overkill.

you already expect concrete types from the p2p

I know what you mean and I've thought about it. I think it was a mistake to have the signatures concrete. I am implementing the port right now, so we can collapse it after if we think that's better.

To be in parity with pre-confirmation service, I think we need to make signatures and public keys to be generic.

But it is more a tech debt. it is why I'm saying maybe we could go without generic for verification now, and implement it later when we try to move to generics for P2P message.

In this case, it will be easy to maintain a code for now, plus you can implement verification logic right away, plus clean up logic based on expiration.

The generics make the tests easy :)

It is true, but in that way, you test more the internal details of how the service works=) Instead of testing how it works on actual inputs from p2p(since you know concrete type).

Using concrete types allows you to encapsulate the logic within the crate without requiring the fuel-core to implement it and test it on the adaptor level=) Plus, you will not expose internal details via the generic because it will be just a logic within the service itself.

That said, I'm also okay with being generic over the signature and public key.

But from a project management perspective, I still prefer to start with an implementation that uses concrete primitives (like known signature and public key). Later, we can always make them generic if we need customization properties. It just speeds up development and allows us to get feedback about the actual implementation earlier(it is what matters at the end). Plus, tests will give coverage over real service instead of facked one.

With the current approach, I think we moved too much logic to the fuel-core. The implementation of the adaptor from #2866 could easily live inside of the service but still be generic over the signature and public key(logic like signature.verify(public_key, message) only should be abstracted).

Co-authored-by: Green Baneling <[email protected]>

…ure-verification-2

## Linked Issues/PRs  ## Description  ## Checklist - [ ] Breaking changes are clearly marked as such in the PR description and changelog - [ ] New behavior is reflected in tests - [ ] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [ ] I have reviewed the code myself - [ ] I have created follow-up issues caused by this PR and linked them here ### After merging, notify other teams [Add or remove entries as needed] - [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/) - [ ] [Sway compiler](https://github.com/FuelLabs/sway/) - [ ] [Platform documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+) (for out-of-organization contributors, the person merging the PR will do this) - [ ] Someone else?

…ure-verification-2

bin/fuel-core/src/cli/run.rs

crates/services/tx_status_manager/src/config.rs

crates/services/tx_status_manager/src/tests/mod.rs

AurelienFT · 2025-03-14T16:53:48Z

crates/services/tx_status_manager/src/service.rs

+                } else {
+                    // TODO: Allow to retry later when a new delegate key is added
+                    tracing::warn!("Preconfirmation signature verification failed, will try once more when a new delegate key is added");
+                    self.early_preconfirmations.push(sealed);
+                }


+1, even if it can be annoying for tests, maybe keep it under test-helpers

…ure-verification-2

crates/services/tx_status_manager/src/service.rs

Added todo

xgreenx

Thank you for the change, very clear tests!=)

…ure-verification-2

## Version 0.42.0 ### Breaking - [2648](#2648): Add feature-flagged field to block header `fault_proving_header` that contains a commitment to all transaction ids. - [2678](#2678): Removed public accessors for `BlockHeader` fields and replaced with methods instead, moved `tx_id_commitment` to the application header of `BlockHeaderV2`. - [2746](#2746): Breaking changes to the CLI arguments: - To disable `random-walk` just don't specify it. Before it required to use `--random-walk 0`. - Next CLI arguments were renamed: - `relayer-min-duration-s` -> `relayer-min-duration` - `relayer-eth-sync-call-freq-s` -> `relayer-eth-sync-call-freq` - `relayer-eth-sync-log-freq-s` -> `relayer-eth-sync-log-freq` - Default value for the `heartbeat-idle-duration` was changed from `1s` to `100ms`. So information about new block will be propagated faster by default. - All CLI arguments below use time(like `100ms`, `1s`, `1d`, etc.) use as a flag argument instead of number of seconds: - `random-walk` - `connection-idle-timeout` - `info-interval` - `identify-interval` - `request-timeout` - `connection-keep-alive` - `heartbeat-send-duration` - `heartbeat-idle-duration` - `heartbeat-check-interval` - `heartbeat-max-avg-interval` - `heartbeat-max-time-since-last` - `relayer-min-duration` - `relayer-eth-sync-call-freq` - `relayer-eth-sync-log-freq` - [2840](#2840): CLI argument `vm-backtrace` is deprecated and does nothing. It will be removed in a future version of `fuel-core`. The `extra_tx_checks` field was renamed into `forbid_fake_coins` that affects JSON based serialization/deserialization. Renamed `extra_tx_checks_default` field into `forbid_fake_coins_default`. ### Added - [2150](#2150): Upgraded `libp2p` to `0.54.1` and introduced `ConnectionLimiter` to limit pending incoming/outgoing connections. - [2491](#2491): Storage read replays of historical blocks for execution tracing. Only available behind `--historical-execution` flag. - [2619](#2619): Add possibility to submit list of changes to rocksdb. - [2666](#2666): Added two new CLI arguments to control the GraphQL queries consistency: `--graphql-block-height-tolerance` (default: `10`) and `--graphql-block-height-min-timeout` (default: `30s`). If a request requires a specific block height and the node is slightly behind, it will wait instead of failing. - [2682](#2682): Added GraphQL APIs to get contract storage and balances for current and past blocks. - [2719](#2719): Merklized DA compression temporal registry tables. - [2722](#2722): Service definition for state root service. - [2724](#2724): Explicit error type for merkleized storage. - [2726](#2726): Add a new gossip-sub message for transaction preconfirmations - [2731](#2731): Include `TemporalRegistry` trait implementations for v2 tables. - [2733](#2733): Add a pending pool transaction that allow transaction to wait a bit of time if an input is missing instead of direct delete. - [2742](#2742): Added API crate for merkle root service. - [2756](#2756): Add new service for managing pre-confirmations - [2769](#2769): Added a new `assembleTx` GraphQL endpoint. The endpoint can be used to assemble the transaction based on the provided requirements. - The returned transaction contains: - Input coins to cover `required_balances` - Input coins to cover the fee of the transaction based on the gas price from `block_horizon` - `Change` or `Destroy` outputs for all assets from the inputs - `Variable` outputs in the case they are required during the execution - `Contract` inputs and outputs in the case they are required during the execution - Reserved witness slots for signed coins filled with `64` zeroes - Set script gas limit(unless `script` is empty) - Estimated predicates, if `estimate_predicates == true` - Returns an error if: - The number of required balances exceeds the maximum number of inputs allowed. - The fee address index is out of bounds. - The same asset has multiple change policies(either the receiver of the change is different, or one of the policies states about the destruction of the token while the other does not). The `Change` output from the transaction also count as a `ChangePolicy`. - The number of excluded coin IDs exceeds the maximum number of inputs allowed. - Required assets have multiple entries. - If accounts don't have sufficient amounts to cover the transaction requirements in assets. - If a constructed transaction breaks the rules defined by consensus parameters. - [2780](#2780): Add implementations for the pre-confirmation signing task - [2784](#2784): Integrate the pre conf signature task into the main consensus task - [2788](#2788): Scaffold dedicated compression service. - [2799](#2799): Add a transaction waiter to the executor to wait for potential new transactions inside the block production window. Add a channel to send preconfirmation created by executor to the other modules Added a new CLI arguments: - `--production-timeout` to control the block production timeout in the case if block producer stuck. - `--poa-open-period` set the block production mode to `Open`. The `Open` mode starts the production of the next block immediately after the previous block. The block is open until the `period` passed. The period is a duration represented by `100ms`, `1s`, `1m`, etc. The manual block production is disabled if this production mode is used. - [2802](#2802): Add a new cache with outputs extracted from the pool for the duration of the block. - [2824](#2824): Introduce new `Try`-like methods for the `TaskNextAction` - [2840](#2840): Added a new CLI arguments: - `assemble-tx-dry-run-limit` - The max number how many times script can be executed during `assemble_tx` GraphQL request. Default value is `3` times. - `assemble-tx-estimate-predicates-limit` - The max number how many times predicates can be estimated during `assemble_tx` GraphQL request. Default values is `10` times. - [2841](#2841): Following endpoints allow estimation of predicates on submission of the transaction via new `estimatePredicates` argument: - `submit` - `submit_and_await` - `submit_and_await_status` The change is backward compatible with all SDKs. The change is not forward-compatible with Rust SDK in the case of the `estiamte_predicates` flag set. - [2844](#2844): Implement DA compression in `fuel-core-compression-service`. - [2845](#2845): New status to manage the pre confirmation status send in `TxUpdateSender`. - [2855](#2855): Add an expiration interval check for pending pool and refactor extracted_outputs to not rely on block creation/process sequence. - [2856](#2856): Add generic logic for managing the signatures and delegate keys for pre-confirmations signatures - [2862](#2862): Derive `enum_iterator::Sequence` and `strum_macros::{EnumCount, IntoStaticStr}` for MerkleizedColumn. ### Changed - [2388](#2388): Rework the P2P service codecs to avoid unnecessary coupling between components. The refactoring makes it explicit that the Gossipsub and RequestResponse codecs only share encoding/decoding functionalities from the Postcard codec. It also makes handling Gossipsub and RequestResponse messages completely independent of each other. - [2460](#2460): The type of the `max_response_size`for the postcard codec used in `RequestResponse` protocols has been changed from `usize` to `u64`. - [2473](#2473): Graphql requests and responses make use of a new `extensions` object to specify request/response metadata. A request `extensions` object can contain an integer-valued `required_fuel_block_height` field. When specified, the request will return an error unless the node's current fuel block height is at least the value specified in the `required_fuel_block_height` field. All graphql responses now contain an integer-valued `current_fuel_block_height` field in the `extensions` object, which contains the block height of the last block processed by the node. - [2618](#2618): Parallelize block/transaction changes creation in Importer - [2653](#2653): Added cleaner error for wasm-executor upon failed deserialization. - [2656](#2656): Migrate test helper function `create_contract` to `fuel_core_types::test_helpers::create_contract`, and refactor test in proof_system/global_merkle_root crate to use this function. - [2659](#2659): Replace `derivative` crate with `educe` crate. - [2705](#2705): Update the default value for `--max-block-size` and `--max-transmit-size` to 50 MB - [2715](#2715): Each GraphQL response contains `current_consensus_parameters_version` and `current_stf_version` in the `extensions` section. - [2723](#2723): Change the way we are building the changelog to avoids conflicts. - [2725](#2725): New txpool worker to remove lock contention - [2752](#2752): Extended the `TransactionStatus` to support pre-confirmations. - [2761](#2761): Renamed `ConsensusParametersProvider` to `ChainStateInfoProvider` because it is now providing more than just info about consensus parameters. - [2767](#2767): Updated fuel-vm to v0.60.0, see [release notes](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.60.0). - [2781](#2781): Deprecate `dryRun` mutation. Use `dryRun` query instead. - [2791](#2791): Added `TxStatusManager` service which serves as a single source of truth regarding the current statuses of transactions - [2793](#2793): Moved common merkle storage trait implementations to `fuel-core-storage` and made it easier to setup a set of columns that need merkleization. - [2799](#2799): Change the block production to not be trigger after an interval but directly after the creation of last block and let the executor run for the block time window. - [2800](#2800): Implement P2P adapter for preconfirmation broadcasting - [2802](#2802): Change new txs notifier to be notified only on executable transactions - [2811](#2811): When the state rewind window of 7d was triggered, the `is_migration_in_progress` was repeatedly called, resulting in multiple iterations over the empty ModificationsHistoryV1 table. Iteration was slow because compaction didn't have a chance to clean up V1 table. We removed iteration from the migration process. - [2824](#2824): Improve conditions where `Error`s in the `PreConfirmationSignatureTask` stop the service - [2840](#2840): Removed `log_backtrace` logic from the executor. It is not needed anymore with the existence of the local debugger for the transactions. - [2865](#2865): Consider the following transaction statuses as final: `Success`, `Failure`, `SqueezedOut`, `PreConfirmationSqueezedOut`. All other statuses will be considered transient. ### Fixed - [2646](#2646): Improved performance of fetching block height by caching it when the view is created. - [2682](#2682): Fixed the issue with RPC consistency feature for the subscriptions(without the fix first we perform the logic of the query, and only after verify the required height). - [2730](#2730): Fixed RocksDB closing issue that potentially could panic. - [2743](#2743): Allow discovery of the peers when slots for functional connections are consumed. Reserved nodes are not affected by the limitation on connections anymore. - [2746](#2746): Fixed flaky part in the e2e tests and version compatibility tests. Speed up compatibility tests execution time. Decreased the default time between block height propagation throw the network. - [2758](#2758): Made `tx_id_commitment` feature flagged in `fuel-core-client`. - [2832](#2832): - Trigger block production only when all other sub services are started. - Fix relayer syncing issue causing block production to slow down occasionally. - [2840](#2840): Fixed `fuel-core-client` receipt deserialization in the case if the `ContractId` is zero. ### Removed - [2863](#2863): Removed everything related to the state root service, as it has been moved to another repo. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: AurelienFT <[email protected]>

## Version 0.42.0 ### Breaking - [2648](FuelLabs/fuel-core#2648): Add feature-flagged field to block header `fault_proving_header` that contains a commitment to all transaction ids. - [2678](FuelLabs/fuel-core#2678): Removed public accessors for `BlockHeader` fields and replaced with methods instead, moved `tx_id_commitment` to the application header of `BlockHeaderV2`. - [2746](FuelLabs/fuel-core#2746): Breaking changes to the CLI arguments: - To disable `random-walk` just don't specify it. Before it required to use `--random-walk 0`. - Next CLI arguments were renamed: - `relayer-min-duration-s` -> `relayer-min-duration` - `relayer-eth-sync-call-freq-s` -> `relayer-eth-sync-call-freq` - `relayer-eth-sync-log-freq-s` -> `relayer-eth-sync-log-freq` - Default value for the `heartbeat-idle-duration` was changed from `1s` to `100ms`. So information about new block will be propagated faster by default. - All CLI arguments below use time(like `100ms`, `1s`, `1d`, etc.) use as a flag argument instead of number of seconds: - `random-walk` - `connection-idle-timeout` - `info-interval` - `identify-interval` - `request-timeout` - `connection-keep-alive` - `heartbeat-send-duration` - `heartbeat-idle-duration` - `heartbeat-check-interval` - `heartbeat-max-avg-interval` - `heartbeat-max-time-since-last` - `relayer-min-duration` - `relayer-eth-sync-call-freq` - `relayer-eth-sync-log-freq` - [2840](FuelLabs/fuel-core#2840): CLI argument `vm-backtrace` is deprecated and does nothing. It will be removed in a future version of `fuel-core`. The `extra_tx_checks` field was renamed into `forbid_fake_coins` that affects JSON based serialization/deserialization. Renamed `extra_tx_checks_default` field into `forbid_fake_coins_default`. ### Added - [2150](FuelLabs/fuel-core#2150): Upgraded `libp2p` to `0.54.1` and introduced `ConnectionLimiter` to limit pending incoming/outgoing connections. - [2491](FuelLabs/fuel-core#2491): Storage read replays of historical blocks for execution tracing. Only available behind `--historical-execution` flag. - [2619](FuelLabs/fuel-core#2619): Add possibility to submit list of changes to rocksdb. - [2666](FuelLabs/fuel-core#2666): Added two new CLI arguments to control the GraphQL queries consistency: `--graphql-block-height-tolerance` (default: `10`) and `--graphql-block-height-min-timeout` (default: `30s`). If a request requires a specific block height and the node is slightly behind, it will wait instead of failing. - [2682](FuelLabs/fuel-core#2682): Added GraphQL APIs to get contract storage and balances for current and past blocks. - [2719](FuelLabs/fuel-core#2719): Merklized DA compression temporal registry tables. - [2722](FuelLabs/fuel-core#2722): Service definition for state root service. - [2724](FuelLabs/fuel-core#2724): Explicit error type for merkleized storage. - [2726](FuelLabs/fuel-core#2726): Add a new gossip-sub message for transaction preconfirmations - [2731](FuelLabs/fuel-core#2731): Include `TemporalRegistry` trait implementations for v2 tables. - [2733](FuelLabs/fuel-core#2733): Add a pending pool transaction that allow transaction to wait a bit of time if an input is missing instead of direct delete. - [2742](FuelLabs/fuel-core#2742): Added API crate for merkle root service. - [2756](FuelLabs/fuel-core#2756): Add new service for managing pre-confirmations - [2769](FuelLabs/fuel-core#2769): Added a new `assembleTx` GraphQL endpoint. The endpoint can be used to assemble the transaction based on the provided requirements. - The returned transaction contains: - Input coins to cover `required_balances` - Input coins to cover the fee of the transaction based on the gas price from `block_horizon` - `Change` or `Destroy` outputs for all assets from the inputs - `Variable` outputs in the case they are required during the execution - `Contract` inputs and outputs in the case they are required during the execution - Reserved witness slots for signed coins filled with `64` zeroes - Set script gas limit(unless `script` is empty) - Estimated predicates, if `estimate_predicates == true` - Returns an error if: - The number of required balances exceeds the maximum number of inputs allowed. - The fee address index is out of bounds. - The same asset has multiple change policies(either the receiver of the change is different, or one of the policies states about the destruction of the token while the other does not). The `Change` output from the transaction also count as a `ChangePolicy`. - The number of excluded coin IDs exceeds the maximum number of inputs allowed. - Required assets have multiple entries. - If accounts don't have sufficient amounts to cover the transaction requirements in assets. - If a constructed transaction breaks the rules defined by consensus parameters. - [2780](FuelLabs/fuel-core#2780): Add implementations for the pre-confirmation signing task - [2784](FuelLabs/fuel-core#2784): Integrate the pre conf signature task into the main consensus task - [2788](FuelLabs/fuel-core#2788): Scaffold dedicated compression service. - [2799](FuelLabs/fuel-core#2799): Add a transaction waiter to the executor to wait for potential new transactions inside the block production window. Add a channel to send preconfirmation created by executor to the other modules Added a new CLI arguments: - `--production-timeout` to control the block production timeout in the case if block producer stuck. - `--poa-open-period` set the block production mode to `Open`. The `Open` mode starts the production of the next block immediately after the previous block. The block is open until the `period` passed. The period is a duration represented by `100ms`, `1s`, `1m`, etc. The manual block production is disabled if this production mode is used. - [2802](FuelLabs/fuel-core#2802): Add a new cache with outputs extracted from the pool for the duration of the block. - [2824](FuelLabs/fuel-core#2824): Introduce new `Try`-like methods for the `TaskNextAction` - [2840](FuelLabs/fuel-core#2840): Added a new CLI arguments: - `assemble-tx-dry-run-limit` - The max number how many times script can be executed during `assemble_tx` GraphQL request. Default value is `3` times. - `assemble-tx-estimate-predicates-limit` - The max number how many times predicates can be estimated during `assemble_tx` GraphQL request. Default values is `10` times. - [2841](FuelLabs/fuel-core#2841): Following endpoints allow estimation of predicates on submission of the transaction via new `estimatePredicates` argument: - `submit` - `submit_and_await` - `submit_and_await_status` The change is backward compatible with all SDKs. The change is not forward-compatible with Rust SDK in the case of the `estiamte_predicates` flag set. - [2844](FuelLabs/fuel-core#2844): Implement DA compression in `fuel-core-compression-service`. - [2845](FuelLabs/fuel-core#2845): New status to manage the pre confirmation status send in `TxUpdateSender`. - [2855](FuelLabs/fuel-core#2855): Add an expiration interval check for pending pool and refactor extracted_outputs to not rely on block creation/process sequence. - [2856](FuelLabs/fuel-core#2856): Add generic logic for managing the signatures and delegate keys for pre-confirmations signatures - [2862](FuelLabs/fuel-core#2862): Derive `enum_iterator::Sequence` and `strum_macros::{EnumCount, IntoStaticStr}` for MerkleizedColumn. ### Changed - [2388](FuelLabs/fuel-core#2388): Rework the P2P service codecs to avoid unnecessary coupling between components. The refactoring makes it explicit that the Gossipsub and RequestResponse codecs only share encoding/decoding functionalities from the Postcard codec. It also makes handling Gossipsub and RequestResponse messages completely independent of each other. - [2460](FuelLabs/fuel-core#2460): The type of the `max_response_size`for the postcard codec used in `RequestResponse` protocols has been changed from `usize` to `u64`. - [2473](FuelLabs/fuel-core#2473): Graphql requests and responses make use of a new `extensions` object to specify request/response metadata. A request `extensions` object can contain an integer-valued `required_fuel_block_height` field. When specified, the request will return an error unless the node's current fuel block height is at least the value specified in the `required_fuel_block_height` field. All graphql responses now contain an integer-valued `current_fuel_block_height` field in the `extensions` object, which contains the block height of the last block processed by the node. - [2618](FuelLabs/fuel-core#2618): Parallelize block/transaction changes creation in Importer - [2653](FuelLabs/fuel-core#2653): Added cleaner error for wasm-executor upon failed deserialization. - [2656](FuelLabs/fuel-core#2656): Migrate test helper function `create_contract` to `fuel_core_types::test_helpers::create_contract`, and refactor test in proof_system/global_merkle_root crate to use this function. - [2659](FuelLabs/fuel-core#2659): Replace `derivative` crate with `educe` crate. - [2705](FuelLabs/fuel-core#2705): Update the default value for `--max-block-size` and `--max-transmit-size` to 50 MB - [2715](FuelLabs/fuel-core#2715): Each GraphQL response contains `current_consensus_parameters_version` and `current_stf_version` in the `extensions` section. - [2723](FuelLabs/fuel-core#2723): Change the way we are building the changelog to avoids conflicts. - [2725](FuelLabs/fuel-core#2725): New txpool worker to remove lock contention - [2752](FuelLabs/fuel-core#2752): Extended the `TransactionStatus` to support pre-confirmations. - [2761](FuelLabs/fuel-core#2761): Renamed `ConsensusParametersProvider` to `ChainStateInfoProvider` because it is now providing more than just info about consensus parameters. - [2767](FuelLabs/fuel-core#2767): Updated fuel-vm to v0.60.0, see [release notes](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.60.0). - [2781](FuelLabs/fuel-core#2781): Deprecate `dryRun` mutation. Use `dryRun` query instead. - [2791](FuelLabs/fuel-core#2791): Added `TxStatusManager` service which serves as a single source of truth regarding the current statuses of transactions - [2793](FuelLabs/fuel-core#2793): Moved common merkle storage trait implementations to `fuel-core-storage` and made it easier to setup a set of columns that need merkleization. - [2799](FuelLabs/fuel-core#2799): Change the block production to not be trigger after an interval but directly after the creation of last block and let the executor run for the block time window. - [2800](FuelLabs/fuel-core#2800): Implement P2P adapter for preconfirmation broadcasting - [2802](FuelLabs/fuel-core#2802): Change new txs notifier to be notified only on executable transactions - [2811](FuelLabs/fuel-core#2811): When the state rewind window of 7d was triggered, the `is_migration_in_progress` was repeatedly called, resulting in multiple iterations over the empty ModificationsHistoryV1 table. Iteration was slow because compaction didn't have a chance to clean up V1 table. We removed iteration from the migration process. - [2824](FuelLabs/fuel-core#2824): Improve conditions where `Error`s in the `PreConfirmationSignatureTask` stop the service - [2840](FuelLabs/fuel-core#2840): Removed `log_backtrace` logic from the executor. It is not needed anymore with the existence of the local debugger for the transactions. - [2865](FuelLabs/fuel-core#2865): Consider the following transaction statuses as final: `Success`, `Failure`, `SqueezedOut`, `PreConfirmationSqueezedOut`. All other statuses will be considered transient. ### Fixed - [2646](FuelLabs/fuel-core#2646): Improved performance of fetching block height by caching it when the view is created. - [2682](FuelLabs/fuel-core#2682): Fixed the issue with RPC consistency feature for the subscriptions(without the fix first we perform the logic of the query, and only after verify the required height). - [2730](FuelLabs/fuel-core#2730): Fixed RocksDB closing issue that potentially could panic. - [2743](FuelLabs/fuel-core#2743): Allow discovery of the peers when slots for functional connections are consumed. Reserved nodes are not affected by the limitation on connections anymore. - [2746](FuelLabs/fuel-core#2746): Fixed flaky part in the e2e tests and version compatibility tests. Speed up compatibility tests execution time. Decreased the default time between block height propagation throw the network. - [2758](FuelLabs/fuel-core#2758): Made `tx_id_commitment` feature flagged in `fuel-core-client`. - [2832](FuelLabs/fuel-core#2832): - Trigger block production only when all other sub services are started. - Fix relayer syncing issue causing block production to slow down occasionally. - [2840](FuelLabs/fuel-core#2840): Fixed `fuel-core-client` receipt deserialization in the case if the `ContractId` is zero. ### Removed - [2863](FuelLabs/fuel-core#2863): Removed everything related to the state root service, as it has been moved to another repo. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: AurelienFT <[email protected]>

MitchTurner added 8 commits March 11, 2025 14:24

WIP

7876706

Add basic trait for adding delegate key

1e27960

Add tests for verifying incoming preconfirmation signatures

8b3eb35

Include test for tracking preconfirmations that return too early for …

136ff89

…their delegate key

Cleanup

37579b6

Update CHANGELOG

af74f22

Merge branch 'master' into feature/pre-confirmations/implement-signat…

fdd2dc6

…ure-verification-2

Add basic impl

a0b531f

MitchTurner marked this pull request as ready for review March 12, 2025 16:12

MitchTurner requested review from a team, Dentosal, netrome and xgreenx as code owners March 12, 2025 16:12

Fix trait method signature

c056e36

AurelienFT previously approved these changes Mar 12, 2025

View reviewed changes

Merge branch 'master' into feature/pre-confirmations/implement-signat…

6683c41

…ure-verification-2

xgreenx reviewed Mar 12, 2025

View reviewed changes

MitchTurner mentioned this pull request Mar 13, 2025

signature verification adaptor #2866

Closed

2 tasks

Update crates/services/tx_status_manager/src/service.rs

b26bbd3

Co-authored-by: Green Baneling <[email protected]>

MitchTurner dismissed AurelienFT’s stale review via b26bbd3 March 13, 2025 05:29

AurelienFT and others added 3 commits March 13, 2025 10:02

Merge branch 'master' into feature/pre-confirmations/implement-signat…

8769da7

…ure-verification-2

Merge branch 'master' into feature/pre-confirmations/implement-signat…

bdbc5fc

…ure-verification-2

AurelienFT mentioned this pull request Mar 14, 2025

Link and activate preconfirmations and add integrations tests #2848

Merged

5 tasks

AurelienFT reviewed Mar 14, 2025

View reviewed changes

MitchTurner added 2 commits March 14, 2025 11:36

Merge branch 'master' into feature/pre-confirmations/implement-signat…

85b5afe

…ure-verification-2

Use ConsensusConfig to get PublicKey (Address actually)

f60f793

MitchTurner requested review from AurelienFT and xgreenx March 14, 2025 20:46

Avoid DoS vector by removing early_preconfirmations concept and test

7d44a66

MitchTurner mentioned this pull request Mar 14, 2025

Rework TxStatusManager tests #2871

Merged

2 tasks

xgreenx reviewed Mar 15, 2025

View reviewed changes

xgreenx and others added 2 commits March 15, 2025 00:30

Apply suggestions from code review

4f40fc0

Fix compilation

b012cdb

Added todo

MitchTurner self-assigned this Mar 15, 2025

xgreenx approved these changes Mar 15, 2025

View reviewed changes

xgreenx requested a review from a team March 15, 2025 04:39

Merge branch 'master' into feature/pre-confirmations/implement-signat…

0402595

…ure-verification-2

AurelienFT approved these changes Mar 17, 2025

View reviewed changes

AurelienFT merged commit aef46bc into master Mar 17, 2025
33 checks passed

AurelienFT deleted the feature/pre-confirmations/implement-signature-verification-2 branch March 17, 2025 10:29

This was referenced Mar 18, 2025

Release v0.42.0 #2877

Merged

test #2878

Closed

Add preconfirmation signature verification to tx status manager #2856

Add preconfirmation signature verification to tx status manager #2856

Uh oh!

Conversation

MitchTurner commented Mar 11, 2025 • edited by xgreenx Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked Issues/PRs

Description

Checklist

Before requesting review

Uh oh!

AurelienFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xgreenx left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MitchTurner commented Mar 11, 2025 •

edited by xgreenx

Loading