-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add preconfirmation signature verification to tx status manager #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AurelienFT
merged 20 commits into
master
from
feature/pre-confirmations/implement-signature-verification-2
Mar 17, 2025
Merged
Changes from 14 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7876706
WIP
MitchTurner 1e27960
Add basic trait for adding delegate key
MitchTurner 8b3eb35
Add tests for verifying incoming preconfirmation signatures
MitchTurner 136ff89
Include test for tracking preconfirmations that return too early for …
MitchTurner 37579b6
Cleanup
MitchTurner af74f22
Update CHANGELOG
MitchTurner fdd2dc6
Merge branch 'master' into feature/pre-confirmations/implement-signat…
MitchTurner a0b531f
Add basic impl
MitchTurner c056e36
Fix trait method signature
MitchTurner 6683c41
Merge branch 'master' into feature/pre-confirmations/implement-signat…
xgreenx b26bbd3
Update crates/services/tx_status_manager/src/service.rs
MitchTurner 8769da7
Merge branch 'master' into feature/pre-confirmations/implement-signat…
AurelienFT 329f7dd
remove trait and replace with concrete impl (#2869)
MitchTurner bdbc5fc
Merge branch 'master' into feature/pre-confirmations/implement-signat…
MitchTurner 85b5afe
Merge branch 'master' into feature/pre-confirmations/implement-signat…
MitchTurner f60f793
Use `ConsensusConfig` to get `PublicKey` (`Address` actually)
MitchTurner 7d44a66
Avoid DoS vector by removing `early_preconfirmations` concept and test
MitchTurner 4f40fc0
Apply suggestions from code review
xgreenx b012cdb
Fix compilation
xgreenx 0402595
Merge branch 'master' into feature/pre-confirmations/implement-signat…
xgreenx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add generic logic for managing the signatures and delegate keys for pre-confirmations signatures |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.