remove trait and replace with concrete impl #2869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchTurner
requested review from
a team,
Dentosal,
netrome and
xgreenx
as code owners
xgreenx
approved these changes
Mar 14, 2025
Collaborator
xgreenx
left a comment
xgreenx
left a comment
There was a problem hiding this comment.
Looks good to me, we can merge it into original PR and fix propagation of the key there=D
Comment on lines
+717
to
+718
| // TODO: Where can I get this value? | ||
| protocol_public_key: Default::default(), |
Collaborator
There was a problem hiding this comment.
You can get it from the chain config like we do during verification of block's fields
MitchTurner
merged commit 329f7dd
into
feature/pre-confirmations/implement-signature-verification-2
14 of 15 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Description
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]