Skip to content

Add Timestamp Sensor#224

Merged
dmulcahey merged 1 commit intozigpy:devfrom
prairiesnpr:sensor_formatter_v2
Oct 17, 2024
Merged

Add Timestamp Sensor#224
dmulcahey merged 1 commit intozigpy:devfrom
prairiesnpr:sensor_formatter_v2

Conversation

@prairiesnpr
Copy link
Copy Markdown
Contributor

Alternative to #222

It does add support for the HVAC Thermostat attribute setpoint_change_source_timestamp, primarily so I would have an attribute to test against.

Closes: #220

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (ff8c635) to head (962707b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #224   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          61       61           
  Lines        9350     9366   +16     
=======================================
+ Hits         9005     9021   +16     
  Misses        345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prairiesnpr prairiesnpr marked this pull request as ready for review October 6, 2024 01:13
@dmulcahey dmulcahey changed the title Support Timestamp Sensor - Use Subclass Add Timestamp Sensor Oct 17, 2024
@prairiesnpr prairiesnpr reopened this Oct 17, 2024
@prairiesnpr prairiesnpr marked this pull request as draft October 17, 2024 11:50
@prairiesnpr prairiesnpr marked this pull request as ready for review October 17, 2024 12:10
@dmulcahey dmulcahey merged commit 3d34a30 into zigpy:dev Oct 17, 2024
@prairiesnpr prairiesnpr deleted the sensor_formatter_v2 branch October 17, 2024 14:52
@TheJulianJES TheJulianJES added the entities Issue or PR about (custom) entities label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

entities Issue or PR about (custom) entities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sensor can only return numeric datatypes

3 participants