Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #222 +/- ##
=======================================
Coverage 96.40% 96.41%
=======================================
Files 61 61
Lines 9359 9373 +14
=======================================
+ Hits 9023 9037 +14
Misses 336 336 ☔ View full report in Codecov by Sentry. |
3 tasks
puddly
reviewed
Oct 5, 2024
| """Pass-through formatter.""" | ||
| return getattr( | ||
| self, | ||
| NON_NUMERIC_FORMATTERS.get(self._attr_device_class, "numeric_formatter"), |
Contributor
There was a problem hiding this comment.
I think it would be clearest to have a single formatter function for the base sensor (converter?) and then have each sub-type override it, having NumericSensor, StringSensor, and DateTimeSensor provide an implementation.
Merged
Contributor
Author
|
Going with #224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does add support for the HVAC Thermostat attribute
setpoint_change_source_timestamp, primarily so I would have an attribute to test against.Closes: #220