[CPU]Update CPU PyTorch to 2.9.0 #29589
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the PyTorch version to 2.9.0 for CPU builds in the project's requirements files. While the core change is correct, it seems some related dependencies were missed. Specifically, torchaudio and torchvision for the ppc64le platform in requirements/cpu.txt need to be updated to versions compatible with PyTorch 2.9.0. Furthermore, I've noticed that some Dockerfiles (e.g., docker/Dockerfile.cpu, docker/Dockerfile.s390x) contain hardcoded references to older PyTorch versions. These should also be updated to ensure consistency across all build and test environments. Addressing these points will help prevent potential dependency conflicts and build failures.
| torch==2.9.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x" | ||
| torch==2.9.0; platform_system == "Darwin" | ||
| torch==2.8.0; platform_machine == "ppc64le" or platform_machine == "aarch64" | ||
| torch==2.9.0; platform_machine == "ppc64le" or platform_machine == "aarch64" |
There was a problem hiding this comment.
While you've updated the torch version for ppc64le to 2.9.0, the corresponding torchaudio and torchvision versions for this platform are still pinned to older versions on lines 16 and 20, respectively. To maintain compatibility with PyTorch 2.9.0, these should be updated. Based on the cuda requirements and PyTorch release information, torchaudio should be version 2.9.0 and torchvision should be 0.24.0.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| torch==2.9.0; platform_machine == "ppc64le" or platform_machine == "aarch64" | ||
|
|
||
| # required for the image processor of minicpm-o-2_6, this must be updated alongside torch | ||
| torchaudio; platform_machine != "ppc64le" and platform_machine != "s390x" |
There was a problem hiding this comment.
On ppc64le we now pin torch==2.9.0, but torchaudio==2.8.0 remains unchanged for the same architecture. Torchaudio 2.8 requires torch 2.8.*, so pip will refuse to resolve this requirements file on ppc64le after the torch upgrade. Please bump the ppc64le torchaudio pin (or keep torch at 2.8) to restore a consistent, installable set.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Good point, I think we should address this
scydas
force-pushed
the
update-cpu-pytorch
branch
4 times, most recently
from
19aae0f to
ec27b5b
Compare
Signed-off-by: scyda <[email protected]>
scydas
force-pushed
the
update-cpu-pytorch
branch
from
ec27b5b to
ea8d4c2
Compare
Signed-off-by: scyda <[email protected]>
|
Please also remove the version guard in test image: Line 135 in da3222f |
Signed-off-by: scyda <[email protected]>
thanks, I have removed the version guard in test image |
hickeyma
left a comment
hickeyma
left a comment
There was a problem hiding this comment.
Should it be updated to the latest version 2.9.1?
|
https://buildkite.com/vllm/fastcheck/builds/44879#019ac51f-0ec7-47a2-b491-d75e4f786cda |
github-actions
bot
added
the
ready
| torch==2.9.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x" | ||
| torch==2.9.0; platform_system == "Darwin" | ||
| torch==2.8.0; platform_machine == "ppc64le" or platform_machine == "aarch64" | ||
| torch==2.9.0; platform_machine == "ppc64le" or platform_machine == "aarch64" |
There was a problem hiding this comment.
Could we hold-off until we check that torch 2.9 works smoothly on Arm?
I'm hoping to get that checked today
If you need that merged now, please keep the 2.8.0 torch version for AArch64 and I'll update that later.
| setuptools-scm>=8 | ||
| --extra-index-url https://download.pytorch.org/whl/cpu | ||
| torch==2.8.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x" | ||
| torch==2.9.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x" |
There was a problem hiding this comment.
Is there a reason why we update to 2.9.0 and not 2.9.1?
There was a problem hiding this comment.
Ahhh I see @bigPYJ1151 message above saying that other backends are not ready.
Do we know what the issue with 2.9.1 is?
|
Arm CI passes with torch 2.9 - we're happy with this change: https://buildkite.com/vllm/ci/builds/40955/steps/canvas?sid=019ac660-dd86-4b9d-b5e9-62dc15691725 |
This reverts commit 35657bc.
|
Reverting in #29647 |
|
Please open a new version of this PR that passes the test. |
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: scyda <[email protected]> Co-authored-by: Li, Jiang <[email protected]>
…project#29647) Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: scyda <[email protected]> Co-authored-by: Li, Jiang <[email protected]> Signed-off-by: Hashem Hashemi <[email protected]>
…project#29647) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Hashem Hashemi <[email protected]>
Signed-off-by: scyda <[email protected]> Co-authored-by: Li, Jiang <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
…project#29647) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
Signed-off-by: scyda <[email protected]> Co-authored-by: Li, Jiang <[email protected]>
…project#29647) Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: scyda <[email protected]> Co-authored-by: Li, Jiang <[email protected]>
…project#29647) Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: scyda <[email protected]> Co-authored-by: Li, Jiang <[email protected]> Signed-off-by: Somoku <[email protected]>
…project#29647) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Somoku <[email protected]>
5 participants
Update CPU PyTorch to 2.9.0
Purpose
Update CPU PyTorch to 2.9.0
Resolve #29579
Test Plan
CI
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.