Revert "[CPU]Update CPU PyTorch to 2.9.0 (#29589)" #29647
Conversation
This reverts commit 35657bc.
DarkLight1337
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the update of CPU PyTorch to version 2.9.0, addressing a CI failure. The changes involve downgrading torch, torchaudio, and torchvision in the relevant requirement files and the CPU Dockerfile. The changes look correct and align with the goal of the revert. I have provided one suggestion in docker/Dockerfile.cpu to make the script more robust and concise.
| sed -i 's/^torch==.*/torch==2.8.0/g' requirements/cpu-test.in && \ | ||
| sed -i 's/torchaudio.*/torchaudio/g' requirements/cpu-test.in && \ | ||
| sed -i 's/torchvision.*/torchvision/g' requirements/cpu-test.in && \ |
There was a problem hiding this comment.
The sed commands for torchaudio and torchvision are not anchored to the start of the line, making them potentially fragile. They could unintentionally modify other parts of the file, such as comments.
For improved robustness and conciseness, you can combine all three sed operations into a single command. This ensures each substitution is anchored to the beginning of the line (^) and is more specific about what it replaces.
sed -i 's/^torch==.*/torch==2.8.0/;s/^torchaudio==.*/torchaudio/;s/^torchvision==.*/torchvision/' requirements/cpu-test.in && \
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
The tests passed |
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Somoku <linsh0@protonmail.com>
…project#29647) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
2 participants
This reverts commit 35657bc.
Purpose
That PR is causing https://buildkite.com/vllm/ci/builds/40985/steps/canvas?jid=019ac81a-0a89-4dca-96dc-c331d4c7a4cf#019ac81a-0a89-4dca-96dc-c331d4c7a4cf to fail
Separately, fix a pre-commit error on main caused by #29594
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.