Skip to content

[CPU]Update CPU PyTorch to 2.9.0 #29589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigPYJ1151 merged 5 commits into from
Nov 28, 2025
Merged

[CPU]Update CPU PyTorch to 2.9.0 #29589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea8d4c2
Update CPU PyTorch to 2.9.0
scydas Nov 27, 2025
a8da632
Update CPU PyTorch to 2.9.0
scydas Nov 27, 2025
122f13f
Merge remote-tracking branch 'origin/update-cpu-pytorch' into update-…
scydas Nov 27, 2025
cb30ccf
Remove dockerfile.cpu Pytorch version guard
scydas Nov 27, 2025
d47816f
Merge branch 'main' into update-cpu-pytorch
bigPYJ1151 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docker/Dockerfile.cpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ FROM base AS vllm-test-deps

WORKDIR /workspace/vllm

# TODO: Update to 2.9.0 when there is a new build for intel_extension_for_pytorch for that version
RUN --mount=type=bind,src=requirements/test.in,target=requirements/test.in \
cp requirements/test.in requirements/cpu-test.in && \
sed -i '/mamba_ssm/d' requirements/cpu-test.in && \
Expand All @@ -132,9 +131,6 @@ RUN --mount=type=bind,src=requirements/test.in,target=requirements/test.in \
esac; \
}; \
remove_packages_not_supported_on_aarch64 && \
sed -i 's/^torch==.*/torch==2.8.0/g' requirements/cpu-test.in && \
sed -i 's/torchaudio.*/torchaudio/g' requirements/cpu-test.in && \
sed -i 's/torchvision.*/torchvision/g' requirements/cpu-test.in && \
uv pip compile requirements/cpu-test.in -o requirements/cpu-test.txt --index-strategy unsafe-best-match --torch-backend cpu

RUN --mount=type=cache,target=/root/.cache/uv \
Expand Down
4 changes: 2 additions & 2 deletions requirements/cpu-build.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ packaging>=24.2
setuptools>=77.0.3,<81.0.0
setuptools-scm>=8
--extra-index-url https://download.pytorch.org/whl/cpu
torch==2.8.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x"
torch==2.9.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x"
Copy link
Contributor

@fadara01 fadara01 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we update to 2.9.0 and not 2.9.1?

Copy link
Contributor

@fadara01 fadara01 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh I see @bigPYJ1151 message above saying that other backends are not ready.
Do we know what the issue with 2.9.1 is?

torch==2.9.0; platform_system == "Darwin"
torch==2.8.0; platform_machine == "ppc64le" or platform_machine == "aarch64"
torch==2.9.0; platform_machine == "ppc64le" or platform_machine == "aarch64"
Copy link
Contributor

@fadara01 fadara01 Nov 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we hold-off until we check that torch 2.9 works smoothly on Arm?
I'm hoping to get that checked today

If you need that merged now, please keep the 2.8.0 torch version for AArch64 and I'll update that later.

scons; platform_machine == "aarch64" # needed to build Arm Compute Library (ACL)
wheel
jinja2>=3.1.6
Expand Down
8 changes: 4 additions & 4 deletions requirements/cpu.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ numba == 0.61.2; platform_machine != "s390x" # Required for N-gram speculative d
packaging>=24.2
setuptools>=77.0.3,<81.0.0
--extra-index-url https://download.pytorch.org/whl/cpu
torch==2.8.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x"
torch==2.9.0+cpu; platform_machine == "x86_64" or platform_machine == "s390x"
torch==2.9.0; platform_system == "Darwin"
torch==2.8.0; platform_machine == "ppc64le" or platform_machine == "aarch64"
torch==2.9.0; platform_machine == "ppc64le" or platform_machine == "aarch64"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While you've updated the torch version for ppc64le to 2.9.0, the corresponding torchaudio and torchvision versions for this platform are still pinned to older versions on lines 16 and 20, respectively. To maintain compatibility with PyTorch 2.9.0, these should be updated. Based on the cuda requirements and PyTorch release information, torchaudio should be version 2.9.0 and torchvision should be 0.24.0.


# required for the image processor of minicpm-o-2_6, this must be updated alongside torch
torchaudio; platform_machine != "ppc64le" and platform_machine != "s390x"
Comment on lines +12 to 15
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align torchaudio pin with torch bump on ppc64le

On ppc64le we now pin torch==2.9.0, but torchaudio==2.8.0 remains unchanged for the same architecture. Torchaudio 2.8 requires torch 2.8.*, so pip will refuse to resolve this requirements file on ppc64le after the torch upgrade. Please bump the ppc64le torchaudio pin (or keep torch at 2.8) to restore a consistent, installable set.

Useful? React with 👍 / 👎.

Copy link
Contributor

@fadara01 fadara01 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I think we should address this

torchaudio==2.8.0; platform_machine == "ppc64le"
torchaudio==2.9.0; platform_machine == "ppc64le"

# required for the image processor of phi3v, this must be updated alongside torch
torchvision; platform_machine != "ppc64le" and platform_machine != "s390x"
torchvision==0.23.0; platform_machine == "ppc64le"
torchvision==0.24.0; platform_machine == "ppc64le"
datasets # for benchmark scripts

# Intel Extension for PyTorch, only for x86_64 CPUs
Expand Down