Skip to content

Add test coverage for non-Tensor embedding field error handling #35729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add test coverage for non-Tensor embedding field error handling #35729

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48d56a1
Initial plan
Copilot Jan 29, 2026
dc64880
Add test case for non-Tensor embedding field
Copilot Jan 29, 2026
e3e1545
Make error message assertion more precise
Copilot Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...st/java/com/yahoo/search/searchers/RelatedDocumentsByNearestNeighborSearcherTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,23 @@ void testDocumentNotFoundReturnsError() {
"Error message was: " + result.hits().getError().getDetailedMessage());
}

@Test
void testNonTensorEmbeddingFieldReturnsError() {
var searcher = new RelatedDocumentsByNearestNeighborSearcher();
var query = new Query("?relatedTo.id=doc1&relatedTo.embeddingField=embedding&relatedTo.queryTensorName=q");

var sourceHit = new Hit("source");
sourceHit.setField("embedding", "not a tensor"); // Field exists but is not a Tensor

var capturedQuery = new Query[1];
var result = executeWithCapture(searcher, query, sourceHit, capturedQuery);

assertNotNull(result.hits().getError(), "Expected error but got none");
String errorMsg = result.hits().getError().getDetailedMessage();
assertTrue(errorMsg.contains("Could not find document") && errorMsg.contains("has no embedding"),
"Error message was: " + errorMsg);
}

@Test
void testNearestNeighborQueryIsCreated() {
var searcher = new RelatedDocumentsByNearestNeighborSearcher();
Expand Down