Add test coverage for non-Tensor embedding field error handling#35729
Open
Add test coverage for non-Tensor embedding field error handling#35729
Conversation
Co-authored-by: andreer <264780+andreer@users.noreply.github.com>
Co-authored-by: andreer <264780+andreer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on related docs query
Add test coverage for non-Tensor embedding field error handling
Jan 29, 2026
andreer
approved these changes
Jan 30, 2026
bjorncs
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting test coverage for when an embedding field exists but contains a non-Tensor value (lines 109-112 in
RelatedDocumentsByNearestNeighborSearcher).Changes
testNonTensorEmbeddingFieldReturnsError()test case that:The test validates that
fetchEmbedding()correctly returnsnullfor non-Tensor fields, triggering the appropriate error message path.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.