chore(t8s-cluster/flux): use centralised HelmRepositories instead of per-instance (#1758)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Centralized Helm chart sources to a fixed namespace (flux-system) and
replaced per-release dynamic repository names with stable names.
* Standardized chart resolution by adding a repository namespace to
chart specs and removing release-name prepending.

* **New Features**
* Added explicit repository URL support and automatic detection of
OCI-style registry URLs.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: cwrau

charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml

@@ -1,14 +1,16 @@
-{{- range $name, $config := .Values.global.helmRepositories }}
-{{- $create := true -}}
-{{- if $config.condition -}}
-  {{- $create = eq (include "common.tplvalues.render" (dict "value" $config.condition "context" (deepCopy $))) "true" -}}
-{{- end -}}
-{{- if $create -}}
+# just for artifacthub image resolving
+{{ if eq .Release.Namespace "default" -}}
+  {{- range $name, $config := .Values.global.helmRepositories -}}
+    {{- $create := true -}}
+    {{- if $config.condition -}}
+      {{- $create = eq (include "common.tplvalues.render" (dict "value" $config.condition "context" (deepCopy $))) "true" -}}
+    {{- end -}}
+    {{- if $create -}}
 apiVersion: source.toolkit.fluxcd.io/v1
 kind: HelmRepository
 metadata:
-  name: {{ printf "%s-%s" $.Release.Name $name | quote }}
-  namespace: {{ $.Release.Namespace }}
+  name: {{ $name | quote }}
+  namespace: flux-system
   labels: {{- include "common.labels.standard" $ | nindent 4 }}
 spec:
   interval: 5m
@@ -17,5 +19,6 @@ spec:
   type: oci
   {{- end }}
 ---
-{{ end -}}
-{{- end }}
+    {{ end -}}
+  {{- end }}
+{{- end -}}

charts/t8s-cluster/templates/workload-cluster/_helmRelease.yaml

@@ -14,8 +14,8 @@ spec:
       version: 0.1.1
       sourceRef:
         kind: HelmRepository
-        name: {{ printf "%s-cetic" .Release.Name }}
-        namespace: {{ .Release.Namespace }}
+        name: cetic
+        namespace: flux-system
   interval: 1h
   driftDetection:
     mode: enabled

charts/t8s-cluster/templates/workload-cluster/cinder-csi-plugin/cinder-csi-plugin.yaml

@@ -13,8 +13,8 @@ spec:
       chart: openstack-cinder-csi
       sourceRef:
         kind: HelmRepository
-        name: {{ printf "%s-cloud-provider-openstack" .Release.Name }}
-        namespace: {{ .Release.Namespace }}
+        name: cloud-provider-openstack
+        namespace: flux-system
       version: {{ $selectedVersion | quote }}
   interval: 1h
   driftDetection:

charts/t8s-cluster/templates/workload-cluster/cloud-controller-manager.yaml

@@ -12,8 +12,8 @@ spec:
       chart: openstack-cloud-controller-manager
       sourceRef:
         kind: HelmRepository
-        name: {{ printf "%s-cloud-provider-openstack" .Release.Name }}
-        namespace: {{ .Release.Namespace }}
+        name: cloud-provider-openstack
+        namespace: flux-system
       version: {{ $selectedVersion | quote }}
   interval: 1h
   driftDetection:

charts/t8s-cluster/templates/workload-cluster/cni-cilium.yaml

@@ -7,7 +7,7 @@ metadata:
   labels: {{- include "common.labels.standard" . | nindent 4 }}
 spec:
   chart:
-    spec: {{- include "common.helm.chartSpec" (dict "repo" "cilium" "prependReleaseName" true "chart" "cilium" "context" $) | nindent 6 }}
+    spec: {{- include "common.helm.chartSpec" (dict "repo" "cilium" "repoNamespace" "flux-system" "chart" "cilium" "context" $) | nindent 6 }}
   interval: 1h
   driftDetection:
     mode: enabled

charts/t8s-cluster/templates/workload-cluster/gpu-operator.yaml

@@ -7,7 +7,7 @@ metadata:
   labels: {{- include "common.labels.standard" . | nindent 4 }}
 spec:
   chart:
-    spec: {{- include "common.helm.chartSpec" (dict "repo" "nvidia" "prependReleaseName" true "chart" "gpu-operator" "context" $) | nindent 6 }}
+    spec: {{- include "common.helm.chartSpec" (dict "repo" "nvidia" "repoNamespace" "flux-system" "chart" "gpu-operator" "context" $) | nindent 6 }}
   interval: 1h
   driftDetection:
     mode: enabled